From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E0A7262A1 for ; Mon, 16 Oct 2023 14:55:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ApmR8dLP" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6BB79C433C8; Mon, 16 Oct 2023 14:55:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1697468147; bh=5PkzNac10/uJkE+iEJPwjLyBm5+nmwP8gkTUh43lUEk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ApmR8dLPSXAfYOFxYjVwnRXbTPEy9Hxu00hgl5ZeEVWY5fa31N7Ka/+25sUAu1B4V tUZP3jgIKZLjWw5kpSzv+nu1qYxdB5/k7JSPgXGf/n8XwpFc4TNhXHtCQMFy0DFdqr iYYsdC23WMRNYvqtQEL9W5PLBJZOG2Xa7dssV6RI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Peter Wang , Bart Van Assche , Stanley Chu , "Martin K. Petersen" Subject: [PATCH 6.5 166/191] scsi: ufs: core: Correct clear TM error log Date: Mon, 16 Oct 2023 10:42:31 +0200 Message-ID: <20231016084019.251681125@linuxfoundation.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231016084015.400031271@linuxfoundation.org> References: <20231016084015.400031271@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.5-stable review patch. If anyone has any objections, please let me know. ------------------ From: Peter Wang commit a20c4350c6a12405b7f732b3ee6801ffe2cc45ce upstream. The clear TM function error log status was inverted. Fixes: 4693fad7d6d4 ("scsi: ufs: core: Log error handler activity") Signed-off-by: Peter Wang Link: https://lore.kernel.org/r/20231003022002.25578-1-peter.wang@mediatek.com Reviewed-by: Bart Van Assche Reviewed-by: Stanley Chu Signed-off-by: Martin K. Petersen Signed-off-by: Greg Kroah-Hartman --- drivers/ufs/core/ufshcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/ufs/core/ufshcd.c +++ b/drivers/ufs/core/ufshcd.c @@ -6955,7 +6955,7 @@ static int ufshcd_clear_tm_cmd(struct uf mask, 0, 1000, 1000); dev_err(hba->dev, "Clearing task management function with tag %d %s\n", - tag, err ? "succeeded" : "failed"); + tag, err < 0 ? "failed" : "succeeded"); out: return err;