From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 667A314F78 for ; Tue, 24 Oct 2023 07:50:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="PSTFqUkj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7BD20C433C8; Tue, 24 Oct 2023 07:50:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1698133810; bh=paAD4Fm02WjfPacN8fv+t+ZeYK8r31ZPb+z4m3rR9AE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PSTFqUkjdRHccDShILgP7snp9kSUsbpAaW4pVTbnd/vl57zBXe5zX2B9IgBtFFJTg OMOJHlkk+tMhw02UQjEq/qQDb5AMbLTY8vSEGr0DrYrngENq/aJMRL5P6HVPpCwfIg miUPs3sBcJ3CB/Kl7wWEioRSyqDyP2tBrIwZNvec= Date: Tue, 24 Oct 2023 09:50:08 +0200 From: Greg Kroah-Hartman To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: stable@vger.kernel.org, patches@lists.linux.dev, Hans de Goede , Sasha Levin Subject: Re: [PATCH 4.19 06/98] platform/x86: hp-wmi:: Mark driver struct with __refdata to prevent section mismatch warning Message-ID: <2023102459-flattery-pegboard-c2a3@gregkh> References: <20231023104813.580375891@linuxfoundation.org> <20231023104813.808917387@linuxfoundation.org> <20231023164057.7rlec7423jeha6sg@pengutronix.de> Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231023164057.7rlec7423jeha6sg@pengutronix.de> On Mon, Oct 23, 2023 at 06:40:57PM +0200, Uwe Kleine-König wrote: > On Mon, Oct 23, 2023 at 12:55:55PM +0200, Greg Kroah-Hartman wrote: > > 4.19-stable review patch. If anyone has any objections, please let me know. > > > > ------------------ > > > > From: Uwe Kleine-König > > > > [ Upstream commit 5b44abbc39ca15df80d0da4756078c98c831090f ] > > > > As described in the added code comment, a reference to .exit.text is ok > > for drivers registered via module_platform_driver_probe(). Make this > > explicit to prevent a section mismatch warning: > > > > WARNING: modpost: drivers/platform/x86/hp/hp-wmi: section mismatch in reference: hp_wmi_driver+0x8 (section: .data) -> hp_wmi_bios_remove (section: .exit.text) > > While that __ref is actually missing since the blamed commit, modpost > only warns about .data -> .exit.text mismatches since > > f177cd0c15fc ("modpost: Don't let "driver"s reference .exit.*") > > (currently in next). So if your goal is to silence warnings in stable, > patches of this type don't need to be backported unless f177cd0c15fc is > backported, too. (But they don't hurt either.) I'll go drop them, thanks! greg k-h