From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59E0E1095F for ; Mon, 30 Oct 2023 11:39:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="m+sQRnkw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 34F0FC433C8; Mon, 30 Oct 2023 11:39:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1698665956; bh=8Wq9ocScwXCiYyTROzBfrzKGUq2KycdYEvF7lpZwvhQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=m+sQRnkwiEGDB8gMMWDes5ow/E7mtSAsiqFF5phrd1S0m2BRl5+Cc68YEfITuOPQw vgB8sONeLnoQg2VTaLI3umvGGjdvczB7mBB+nSzNWZ921RaMV1huO7HO4n7vElVT3Q vRRELPKtqTjjdsHwftVZgCHC8NqL8dk23JPttNyk= Date: Mon, 30 Oct 2023 12:39:13 +0100 From: Greg KH To: Oliver Hartkopp Cc: stable@vger.kernel.org, sashal@kernel.org, linux-can@vger.kernel.org, lukas.magel@posteo.net, patches@lists.linux.dev, maxime.jayat@mobile-devices.fr, mkl@pengutronix.de, michal.sojka@cvut.cz Subject: Re: [PATCH] can: isotp: upgrade 5.10 LTS to latest 6.6 mainline code base Message-ID: <2023103002-squiggly-handrail-09ba@gregkh> References: <20231030113027.3387-1-socketcan@hartkopp.net> Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231030113027.3387-1-socketcan@hartkopp.net> On Mon, Oct 30, 2023 at 12:30:27PM +0100, Oliver Hartkopp wrote: > The backport of commit 9c5df2f14ee3 ("can: isotp: isotp_ops: fix poll() to > not report false EPOLLOUT events") introduced a new regression where the > fix could potentially introduce new side effects. > > To reduce the risk of other unmet dependencies and missing fixes and checks > the latest mainline code base is ported back to the 5.10 LTS tree. > > To meet the former Linux 5.10 API these commits have been reverted: > e3ae2365efc1 ("net: sock: introduce sk_error_report") > f4b41f062c42 ("net: remove noblock parameter from skb_recv_datagram()") > 96a7457a14d9 ("can: skb: unify skb CAN frame identification helpers") > dc97391e6610 ("sock: Remove ->sendpage*() in favour of sendmsg(MSG_SPLICE_PAGES)") > 0145462fc802 ("can: isotp: isotp_recvmsg(): use sock_recv_cmsgs() to get SOCK_RXQ_OVFL infos") > > New features and communication stability measures: > 9f39d36530e5 ("can: isotp: add support for transmission without flow control") > 96d1c81e6a04 ("can: isotp: add module parameter for maximum pdu size") > 4b7fe92c0690 ("can: isotp: add local echo tx processing for consecutive frames") > 530e0d46c613 ("can: isotp: set default value for N_As to 50 micro seconds") > > And various sanity checks, fixes and improved return values. > > Signed-off-by: Oliver Hartkopp > --- > include/uapi/linux/can/isotp.h | 25 +- > net/can/isotp.c | 495 ++++++++++++++++++++++----------- > 2 files changed, 347 insertions(+), 173 deletions(-) Same here, sorry, we need the individual commits. greg k-h