From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3587DDBF for ; Wed, 29 Nov 2023 06:18:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--moritzf.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="pqm5v/z+" Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-da2b8af7e89so7447190276.1 for ; Tue, 28 Nov 2023 22:18:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1701238707; x=1701843507; darn=lists.linux.dev; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=8J4qMZXxn7dMNLyiBgKsZSJFUlenzauaBGTwqmqEkBs=; b=pqm5v/z+NTP5elPNkwkc6Ym4xu9AqcFYVei2SsIXPc5z+p2U0HHH0yUNDhj+yIkw8B f/MTZGh9PpGaglo8TX7ecFM17C2nPeJzoMtlKzsbhibgVp3vJSLQqORyjn+5Xk9vqANF C5mKtunvSqxxTNlbmTFC3XP7dukV/+k6g9/yvFQ4cPymWj0SSMEh4lEEYjRmBWjvDLfT 6Al54PQuyu5uBdZZbp5c9+XBcr8W9KpyjfY6VGg/3B/+H9gcih3YYZYqWbqIe1pcuXj4 y9kGY2Ip9IwDBCXjrkXhuIem7X4LyR1h/UFmQv5D1pbaCsJ2ki9bEJX6dEx/NXEqUrVd Ft6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701238707; x=1701843507; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8J4qMZXxn7dMNLyiBgKsZSJFUlenzauaBGTwqmqEkBs=; b=hbFzZH71RsiElzOkAGaZss5/cuXIXm7omIZOIVzirfn2lmZt6U4NgkKhNJWqrdwm2Q 2xXKvEA9fYNfajLDJd/id8Fv2lgjxNbvn7geqVOFN3BBWDCsyZ/tP31Fwxj3ZacwWuKW y6PSrRkV7gYvTPbk6kwNXsJRogfDladFud0q8sbaHlwtY/wcBaJL0PEqERAOGPZOuv0M TibOwQoZ75KHj9x6TWyN3Q3stIur1U+cI4qIglIDqCRnPgHUHGdozapTPaoYQAGVgDzw YFJflZHvkjX8IjZ+Soeq8xwwajg3hqhEm6r4+K3H8Ij20JZ9vLInTwRhfDXR4Kd74rEk XwMw== X-Gm-Message-State: AOJu0Yx1oXtV7Koi9AXRqPBJ3p6w1BFbV8gy1xJc9tcr03igS4T4oyU8 fSpNTsx0WMoCQ76826eyz524LC64cXAC X-Google-Smtp-Source: AGHT+IFcUygGdfS95PQxvEDzLlpossLvNyVov+P9EiIyJqoPwhfNYT1rdzAgRP7ca8iJPDCSOmBZ7cELCldp X-Received: from morats.c.googlers.com ([fda3:e722:ac3:cc00:14:4d90:c0a8:d9e]) (user=moritzf job=sendgmr) by 2002:a25:d287:0:b0:db3:8b00:22eb with SMTP id j129-20020a25d287000000b00db38b0022ebmr482941ybg.6.1701238706756; Tue, 28 Nov 2023 22:18:26 -0800 (PST) Date: Wed, 29 Nov 2023 06:18:25 +0000 In-Reply-To: <9-v1-720585788a7d+811b-iommu_fwspec_p1_jgg@nvidia.com> Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <0-v1-720585788a7d+811b-iommu_fwspec_p1_jgg@nvidia.com> <9-v1-720585788a7d+811b-iommu_fwspec_p1_jgg@nvidia.com> Message-ID: <20231129061825.altvhmgltws2bvhh@google.com> Subject: Re: [PATCH 09/10] ACPI: IORT: Cast from ULL to phys_addr_t From: Moritz Fischer To: Jason Gunthorpe Cc: David Airlie , Alyssa Rosenzweig , Albert Ou , asahi@lists.linux.dev, Catalin Marinas , Danilo Krummrich , Daniel Vetter , Dexuan Cui , devicetree@vger.kernel.org, dmaengine@vger.kernel.org, dri-devel@lists.freedesktop.org, David Woodhouse , Frank Rowand , Hanjun Guo , Haiyang Zhang , iommu@lists.linux.dev, Jon Hunter , Joerg Roedel , Karol Herbst , Krzysztof Kozlowski , "K. Y. Srinivasan" , Laxman Dewangan , Len Brown , linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, linux-mips@vger.kernel.org, linux-riscv@lists.infradead.org, linux-snps-arc@lists.infradead.org, linux-tegra@vger.kernel.org, Russell King , Lorenzo Pieralisi , Lyude Paul , Marek Szyprowski , nouveau@lists.freedesktop.org, Palmer Dabbelt , Paul Walmsley , "Rafael J. Wysocki" , Rob Herring , Robin Murphy , Sudeep Holla , Suravee Suthikulpanit , Sven Peter , Thomas Bogendoerfer , Vineet Gupta , Vinod Koul , Wei Liu , Will Deacon , Lu Baolu , Christoph Hellwig , Jerry Snitselaar , Hector Martin , Moritz Fischer , patches@lists.linux.dev, "Rafael J. Wysocki" , Rob Herring , Thierry Reding Content-Type: text/plain; charset="UTF-8"; format=flowed; delsp=yes On Tue, Nov 28, 2023 at 08:48:05PM -0400, Jason Gunthorpe wrote: > gcc on i386 (when compile testing) warns: This is a weird test. The Makefile for drivers/acpi/arm64 is conditional on CONFIG_ARM64. How does this happen? > 8->8 obj-$(CONFIG_ARM64) += arm64/ > 8->8 > drivers/acpi/arm64/iort.c:2014:18: warning: implicit conversion > from 'unsigned long long' to 'phys_addr_t' (aka 'unsigned int') changes > value from 18446744073709551615 to 4294967295 [-Wconstant-conversion] > local_limit = > DMA_BIT_MASK(ncomp->memory_address_limit); > Because DMA_BIT_MASK returns a large ULL constant. Explicitly truncate it > to phys_addr_t. > Signed-off-by: Jason Gunthorpe > --- > drivers/acpi/arm64/iort.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c > index 6496ff5a6ba20d..bdaf9256870d92 100644 > --- a/drivers/acpi/arm64/iort.c > +++ b/drivers/acpi/arm64/iort.c > @@ -2011,7 +2011,8 @@ phys_addr_t __init > acpi_iort_dma_get_max_cpu_address(void) > case ACPI_IORT_NODE_NAMED_COMPONENT: > ncomp = (struct acpi_iort_named_component *)node->node_data; > - local_limit = DMA_BIT_MASK(ncomp->memory_address_limit); > + local_limit = (phys_addr_t)DMA_BIT_MASK( > + ncomp->memory_address_limit); > limit = min_not_zero(limit, local_limit); > break; > @@ -2020,7 +2021,8 @@ phys_addr_t __init > acpi_iort_dma_get_max_cpu_address(void) > break; > rc = (struct acpi_iort_root_complex *)node->node_data; > - local_limit = DMA_BIT_MASK(rc->memory_address_limit); > + local_limit = (phys_addr_t)DMA_BIT_MASK( > + rc->memory_address_limit); > limit = min_not_zero(limit, local_limit); > break; > } > -- > 2.42.0 Cheers, Moritz