From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F34D31D6B8; Wed, 3 Jan 2024 21:48:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LmZSOIZO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E69F1C433C7; Wed, 3 Jan 2024 21:48:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704318486; bh=EoLFqN4fTvEb2iwmbSi8aLstNN2RD040+Twiol5JYs8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LmZSOIZO+7Qc6DqawX/nH0LGJJRXIUeKf74TrB38WjC7ifoZqTY6jefH0kTYpKV77 3+z5g8O6FfjvkfUXYC6Cz3D0FLRahIQCNrfGcpFrHgxtEwPZpKaPTbaeZTKBoo9IjQ WsG0yME1zk6vN3tt/iZhWPXkRhbldYC2/cFUbwZaau5utfr9iW1XCiKJ7sBLQn8mAS H2nDuh0U0oJsLtjjp8UiFEz/YJagHfW9EMDiJpbxXAH5fq7zPKE62TgqSscNN9odJH okCWQdbk6Xev2Do4+w5EKtx3b/gt1rIzBme3ftbTWLaLjtP5HoshcOPuSJnX5JMfcw 9fjwiumPzpIaw== Date: Wed, 3 Jan 2024 14:48:04 -0700 From: Nathan Chancellor To: Borislav Petkov Cc: tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, mhiramat@kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, patches@lists.linux.dev Subject: Re: [PATCH] x86/tools: objdump_reformat.awk: Skip bad instructions from llvm-objdump Message-ID: <20240103214804.GA155391@dev-arch.thelio-3990X> References: <20231205-objdump_reformat-awk-handle-llvm-objdump-bad_expr-v1-1-b4a74f39396f@kernel.org> <20240103181542.GA629234@dev-arch.thelio-3990X> <20240103181852.GDZZWlDJMVvqAZdpfV@fat_crate.local> <20240103205506.GA152662@dev-arch.thelio-3990X> <20240103212616.GGZZXQ+IKGPb+EqVcu@fat_crate.local> Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240103212616.GGZZXQ+IKGPb+EqVcu@fat_crate.local> On Wed, Jan 03, 2024 at 10:26:16PM +0100, Borislav Petkov wrote: > On Wed, Jan 03, 2024 at 01:55:06PM -0700, Nathan Chancellor wrote: > > On Wed, Jan 03, 2024 at 07:18:52PM +0100, Borislav Petkov wrote: > > > On Wed, Jan 03, 2024 at 11:15:42AM -0700, Nathan Chancellor wrote: > > > > Ping? I am still seeing this issue. > > > > > > Does this need a Fixes tag and needs to go to Linus now or are you fine > > > with 6.8-rc0? > > > > This is only needed due to the recent changes from Sam and myself in > > x86/build > > I don't understand: those three commits seem unrelated to LLVM objdump > outputting "". > > Or are you saying that you've *started* running the insn decoder selftest > with llvm's objdump and those three commits are addressing differences > in the output and this outstanding commit is needed too for the bad > opcode case? Prior to commit 5225952d74d4 ("x86/tools: Remove chkobjdump.awk"), the insn decoder selftest would not actually run with llvm-objdump altogether because chkobjdump.awk would fail (because it was only written for GNU objdump). The two commits prior to 5225952d74d4 were cleaning up differences between the output of each objdump implementations and this change should have been a part of that work as well, I just did not build enough configurations to see it. Hopefully that clears things up. Cheers, Nathan