From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F1B62033B; Thu, 18 Jan 2024 11:03:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705575792; cv=none; b=bIrqbEr7CUHC9/bccxOmSDxZkDQyxrwlEfYg2eaRH7Mr08iEUKOGhFJRj2H+CExB9NiXno5K1mrUs04r9EQSzV3yW9qLW4SM3VUpvtXb7QWGLkL7rkedppCuyoSfvukATYTxJu8erl8p3cM/Sd9/gDCwkPwpo9xIEDvbzP6LF0k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705575792; c=relaxed/simple; bh=wDHpJK6nYH9xVuvoYVeD58Gzc2jbY4cH1wiM5gPMXHs=; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID: X-Mailer:In-Reply-To:References:User-Agent:X-stable: X-Patchwork-Hint:MIME-Version:Content-Transfer-Encoding; b=IvfxZhgB1yDCSUUz+370hTKNbvigSPO/vl4CusiYcmCI6ardxvmPDuYdR2MiNrEbUaK/Jgq/vsrh5hu6gz0uwRFAeaa80KD/4MqPhgu6w4QDTVCCkGFZdQ1qsAF0u1FSIdzhMlSIBDisqSh1+WGeeSLizgB42eN2r/dCdUhi/5I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Qk01s7tC; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Qk01s7tC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D5C22C43394; Thu, 18 Jan 2024 11:03:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1705575792; bh=wDHpJK6nYH9xVuvoYVeD58Gzc2jbY4cH1wiM5gPMXHs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Qk01s7tCQQ3VWZGnFu7su36u163K2l8fMjNMG6TAoS10wdFzWviBaPNlFAaJmHBkw 1KRqHYxiobnBiY2tsZh9vddRWPM1rPVUOwFFdtKaVkDspdYNgC7mtqiGZNlu1rUcW7 lBp0tb0rcntpltETiLN9SQOToBdxo8OF3jtjiDao= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, kernel test robot , Mike Leach , James Clark , Suzuki K Poulose Subject: [PATCH 6.1 099/100] coresight: etm4x: Fix width of CCITMIN field Date: Thu, 18 Jan 2024 11:49:47 +0100 Message-ID: <20240118104315.137834517@linuxfoundation.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240118104310.892180084@linuxfoundation.org> References: <20240118104310.892180084@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: James Clark commit cc0271a339cc70cae914c3ec20edc2a8058407da upstream. CCITMIN is a 12 bit field and doesn't fit in a u8, so extend it to u16. This probably wasn't an issue previously because values higher than 255 never occurred. But since commit 4aff040bcc8d ("coresight: etm: Override TRCIDR3.CCITMIN on errata affected cpus"), a comparison with 256 was done to enable the errata, generating the following W=1 build error: coresight-etm4x-core.c:1188:24: error: result of comparison of constant 256 with expression of type 'u8' (aka 'unsigned char') is always false [-Werror,-Wtautological-constant-out-of-range-compare] if (drvdata->ccitmin == 256) Cc: stable@vger.kernel.org Fixes: 2e1cdfe184b5 ("coresight-etm4x: Adding CoreSight ETM4x driver") Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202310302043.as36UFED-lkp@intel.com/ Reviewed-by: Mike Leach Signed-off-by: James Clark Signed-off-by: Suzuki K Poulose Link: https://lore.kernel.org/r/20231101115206.70810-1-james.clark@arm.com Signed-off-by: Greg Kroah-Hartman --- drivers/hwtracing/coresight/coresight-etm4x.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/hwtracing/coresight/coresight-etm4x.h +++ b/drivers/hwtracing/coresight/coresight-etm4x.h @@ -1032,7 +1032,7 @@ struct etmv4_drvdata { u8 ctxid_size; u8 vmid_size; u8 ccsize; - u8 ccitmin; + u16 ccitmin; u8 s_ex_level; u8 ns_ex_level; u8 q_support;