From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E077412A17F; Tue, 23 Jan 2024 00:13:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705968831; cv=none; b=co/a8tpXXXD5FrKFN6IYiUCb5Dk/UcfStfwlHNiX9LxvY2+PEpLz0BGxRaZoLNhmzgH3fSe3fx+Hzf362J67fA2YQJ1l9goLJoMm93IjStVMjiTM3Lpt7cmyla5JBkUOeV5DzFmMv3Uo4llkIOKykoVgcFQwGToZ0K78pMFd3Io= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705968831; c=relaxed/simple; bh=11vpH7awHhxY8edBRrcavOBnbReJz0SmS8r2g6LHX/A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NBN35NCVRZPw6n3eyHlHso5VIDo5CoIdacPt4eggvCit6FhJ2GvLGdA2woHXc7yUQS6y26CyTGq3DBwvguEKDdwLmL7OQxxNMyiw7ALh/bSsY3v53p3QP9hszQcb+URnzuADvrpDg5NWu8EnmPkNuwR90oYVwX5vyipT5Z+w8Mk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=sUyQjpf2; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="sUyQjpf2" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7CEB9C433F1; Tue, 23 Jan 2024 00:13:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1705968830; bh=11vpH7awHhxY8edBRrcavOBnbReJz0SmS8r2g6LHX/A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sUyQjpf2G/XyBmXzDdsSHt2f1vh3fGgVsR5aUSN8eXXEJit8vhrwH65VJLzrybFBe r0HP8vT+aRI6nniBGh4NjRf/jY1XA0bDbFje8FcyHPgc4Wb9GLmekUOiPvwqceeU1v GrFaJEAFqNtonkbd+antz9AwVFkoyrg3WWwrdzMA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Dinghao Liu , Tom Lendacky , Herbert Xu , Sasha Levin Subject: [PATCH 5.4 063/194] crypto: ccp - fix memleak in ccp_init_dm_workarea Date: Mon, 22 Jan 2024 15:56:33 -0800 Message-ID: <20240122235721.906278973@linuxfoundation.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240122235719.206965081@linuxfoundation.org> References: <20240122235719.206965081@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Dinghao Liu [ Upstream commit a1c95dd5bc1d6a5d7a75a376c2107421b7d6240d ] When dma_map_single() fails, wa->address is supposed to be freed by the callers of ccp_init_dm_workarea() through ccp_dm_free(). However, many of the call spots don't expect to have to call ccp_dm_free() on failure of ccp_init_dm_workarea(), which may lead to a memleak. Let's free wa->address in ccp_init_dm_workarea() when dma_map_single() fails. Fixes: 63b945091a07 ("crypto: ccp - CCP device driver and interface support") Signed-off-by: Dinghao Liu Acked-by: Tom Lendacky Signed-off-by: Herbert Xu Signed-off-by: Sasha Levin --- drivers/crypto/ccp/ccp-ops.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/ccp/ccp-ops.c b/drivers/crypto/ccp/ccp-ops.c index e826c4b6b3af..4865eb047866 100644 --- a/drivers/crypto/ccp/ccp-ops.c +++ b/drivers/crypto/ccp/ccp-ops.c @@ -178,8 +178,11 @@ static int ccp_init_dm_workarea(struct ccp_dm_workarea *wa, wa->dma.address = dma_map_single(wa->dev, wa->address, len, dir); - if (dma_mapping_error(wa->dev, wa->dma.address)) + if (dma_mapping_error(wa->dev, wa->dma.address)) { + kfree(wa->address); + wa->address = NULL; return -ENOMEM; + } wa->dma.length = len; } -- 2.43.0