From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BCAB12A17F; Tue, 23 Jan 2024 00:14:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705968869; cv=none; b=GmywAqGxC2csHiIci+vDKb6admOjrVZCf1/mgQeaMay5KZeLVpIQ7ybJ5Ch7QhsZDzrwcXxcZYrfV/FAepaiHlHa+sprHBXFpkMSF+0S+HOGKggzOJLvU3EhwG2ZDt+fR+YHoYYpYn4q1VZupiFzMiUi+a2M4ZNNGMCj0zSalJ0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705968869; c=relaxed/simple; bh=iTvglnLu/ahWD1yWzGic54q7DTIp5SGinRAYgyWocfo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lfanFVZCcVrEcpcjSxeh8auRWIGAz3cKOTRTVn8BZ7tCn+BgL1eQ2eluJMIgfoeBkbAZktZYiBt0MEWS7PpgZcLO6qC+tzCe1sgYF5lW4OM2I4ReWu5SFeDajhhFG00ZYv+vphmir8Q4pBHjUMrq6/X9eHeyfkZSAEzGH6rBqCM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=zz63Ec5B; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="zz63Ec5B" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3FE4DC43394; Tue, 23 Jan 2024 00:14:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1705968869; bh=iTvglnLu/ahWD1yWzGic54q7DTIp5SGinRAYgyWocfo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=zz63Ec5B6YDIQcmGJbRYUWzeF52aGc6h6Wuc3Z7G+/8zqZ/1zA0PIs7M/YEUCyST1 dSXHymH1JYF3C+JzdA8xMZWP1tdTAm7l7sRpFwXbykYKdTG8RgU0plyqubm+LpDn+v RpahnDNIVOZxcWPTXTQijVopkZUJARgWve27mzIc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Ovidiu Panait , Herbert Xu , Sasha Levin Subject: [PATCH 5.4 075/194] crypto: sahara - fix processing hash requests with req->nbytes < sg->length Date: Mon, 22 Jan 2024 15:56:45 -0800 Message-ID: <20240122235722.450989044@linuxfoundation.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240122235719.206965081@linuxfoundation.org> References: <20240122235719.206965081@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ovidiu Panait [ Upstream commit 7bafa74d1ba35dcc173e1ce915e983d65905f77e ] It's not always the case that the entire sg entry needs to be processed. Currently, when nbytes is less than sg->length, "Descriptor length" errors are encountered. To fix this, take the actual request size into account when populating the hw links. Fixes: 5a2bb93f5992 ("crypto: sahara - add support for SHA1/256") Signed-off-by: Ovidiu Panait Signed-off-by: Herbert Xu Signed-off-by: Sasha Levin --- drivers/crypto/sahara.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/sahara.c b/drivers/crypto/sahara.c index dbccf9264406..0f4bb8574a4a 100644 --- a/drivers/crypto/sahara.c +++ b/drivers/crypto/sahara.c @@ -792,6 +792,7 @@ static int sahara_sha_hw_links_create(struct sahara_dev *dev, int start) { struct scatterlist *sg; + unsigned int len; unsigned int i; int ret; @@ -813,12 +814,14 @@ static int sahara_sha_hw_links_create(struct sahara_dev *dev, if (!ret) return -EFAULT; + len = rctx->total; for (i = start; i < dev->nb_in_sg + start; i++) { - dev->hw_link[i]->len = sg->length; + dev->hw_link[i]->len = min(len, sg->length); dev->hw_link[i]->p = sg->dma_address; if (i == (dev->nb_in_sg + start - 1)) { dev->hw_link[i]->next = 0; } else { + len -= min(len, sg->length); dev->hw_link[i]->next = dev->hw_phys_link[i + 1]; sg = sg_next(sg); } -- 2.43.0