From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FC8C13BEA7; Tue, 23 Jan 2024 00:23:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705969432; cv=none; b=AbuMfwjNt/zGFKq+pAYeRo+hXuqbJEPrHY1Ok2JTlx/QSIpz2z3hbqoFY+U3fVwkiUb8JuYRl1UnhhrLSvQnuObFB+C07yffv2kTGQktf+thH9NeCMmNL1nMCeie9QAqD5SiD2jI/n0vhZ0UwtFtWOP1ooJAo+5sDW1eWKMIT4w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705969432; c=relaxed/simple; bh=uzYQy4NT+HMjvMrSiKiJNL7fWfOVF6HGxSTC7dvAAao=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZrP/Mkf9OjVbY6GDQkGpch+5l03qKEwz31aP3fGIYT0yNVrIAXwefkuih890qVlDnlEWn6xYi3LF4ZFKM/0BaVvhzsOF7nkHmULZjDD5x/bcBOrmii28+fPKlPHhjuU/wLxSOEZ5YczOKBzjsd6WK8neIJ2vByW9GtwaDyA53uo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=gsGXBWHt; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="gsGXBWHt" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 97EA9C43390; Tue, 23 Jan 2024 00:23:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1705969431; bh=uzYQy4NT+HMjvMrSiKiJNL7fWfOVF6HGxSTC7dvAAao=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gsGXBWHtdIqY+V9YOyRBtbwWIsdRci2husnLl/ytjwv1b9gFSTCEd18cANb15/4Nu qUigA87YvL6/lb7Akfx28kCWU7XIQaVA5Zzx2DScQgpO8gBLbmn4phRkBNHybIsDgu zglK5FaBZ8TNwbcfkaLNiWUO8LpsdvxeglSNbTx4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Johannes Berg , Gregory Greenman , Miri Korenblit , Sasha Levin Subject: [PATCH 6.7 217/641] wifi: iwlwifi: mvm: send TX path flush in rfkill Date: Mon, 22 Jan 2024 15:52:01 -0800 Message-ID: <20240122235824.732984473@linuxfoundation.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240122235818.091081209@linuxfoundation.org> References: <20240122235818.091081209@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.7-stable review patch. If anyone has any objections, please let me know. ------------------ From: Johannes Berg [ Upstream commit 2afc3dad39ea84a072d04ff40a417234326adc47 ] If we want to drop packets, that's surely a good thing to do when we want to enter rfkill. Send this command despite rfkill so we can successfully clean up everything, we need to handle it separately since it has CMD_WANT_SKB, so it's not going to automatically return success when in rfkill. Fixes: d4e3a341b87b ("iwlwifi: mvm: add support for new flush queue response") Signed-off-by: Johannes Berg Reviewed-by: Gregory Greenman Signed-off-by: Miri Korenblit Link: https://msgid.link/20231219215605.c528a6fa6cec.Ibe5e9560359ccc0fba60c35e01de285c376748a2@changeid Signed-off-by: Johannes Berg Signed-off-by: Sasha Levin --- drivers/net/wireless/intel/iwlwifi/mvm/tx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/tx.c b/drivers/net/wireless/intel/iwlwifi/mvm/tx.c index ae5cd13cd6dd..db986bfc4dc3 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/tx.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/tx.c @@ -2256,7 +2256,7 @@ int iwl_mvm_flush_sta_tids(struct iwl_mvm *mvm, u32 sta_id, u16 tids) WARN_ON(!iwl_mvm_has_new_tx_api(mvm)); if (iwl_fw_lookup_notif_ver(mvm->fw, LONG_GROUP, TXPATH_FLUSH, 0) > 0) - cmd.flags |= CMD_WANT_SKB; + cmd.flags |= CMD_WANT_SKB | CMD_SEND_IN_RFKILL; IWL_DEBUG_TX_QUEUES(mvm, "flush for sta id %d tid mask 0x%x\n", sta_id, tids); -- 2.43.0