From: Ashok Raj <ashok.raj@intel.com>
To: Hans de Goede <hdegoede@redhat.com>,
Ilpo Jarvinen <ilpo.jarvinen@linux.intel.com>,
markgross@kernel.org
Cc: Jithu Joseph <jithu.joseph@intel.com>,
rostedt@goodmis.org, ashok.raj@intel.com, tony.luck@intel.com,
LKML <linux-kernel@vger.kernel.org>,
platform-driver-x86@vger.kernel.org, patches@lists.linux.dev,
pengfei.xu@intel.com
Subject: [PATCH 3/5] platform/x86/intel/ifs: Add current batch number to trace output
Date: Thu, 25 Jan 2024 00:22:52 -0800 [thread overview]
Message-ID: <20240125082254.424859-4-ashok.raj@intel.com> (raw)
In-Reply-To: <20240125082254.424859-1-ashok.raj@intel.com>
Add the current batch number in the trace output. When there are failures,
it's important to know which test content resulted in failure.
# TASK-PID CPU# ||||| TIMESTAMP FUNCTION
# | | | ||||| | |
migration/0-18 [000] d..1. 527287.084668: ifs_status: batch: 02, start: 0000, stop: 007f, status: 0000000000007f80
migration/128-785 [128] d..1. 527287.084669: ifs_status: batch: 02, start: 0000, stop: 007f, status: 0000000000007f80
Signed-off-by: Ashok Raj <ashok.raj@intel.com>
Reviewed-by: Tony Luck <tony.luck@intel.com>
---
include/trace/events/intel_ifs.h | 9 ++++++---
drivers/platform/x86/intel/ifs/runtest.c | 2 +-
2 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/include/trace/events/intel_ifs.h b/include/trace/events/intel_ifs.h
index 8462dfb7a020..8ce2de120f2d 100644
--- a/include/trace/events/intel_ifs.h
+++ b/include/trace/events/intel_ifs.h
@@ -10,23 +10,26 @@
TRACE_EVENT(ifs_status,
- TP_PROTO(int start, int stop, u64 status),
+ TP_PROTO(int batch, int start, int stop, u64 status),
- TP_ARGS(start, stop, status),
+ TP_ARGS(batch, start, stop, status),
TP_STRUCT__entry(
+ __field( int, batch )
__field( u64, status )
__field( u16, start )
__field( u16, stop )
),
TP_fast_assign(
+ __entry->batch = batch;
__entry->start = start;
__entry->stop = stop;
__entry->status = status;
),
- TP_printk("start: %.4x, stop: %.4x, status: %.16llx",
+ TP_printk("batch: %.2d, start: %.4x, stop: %.4x, status: %.16llx",
+ __entry->batch,
__entry->start,
__entry->stop,
__entry->status)
diff --git a/drivers/platform/x86/intel/ifs/runtest.c b/drivers/platform/x86/intel/ifs/runtest.c
index c8352ffb9195..21dc0046fd9b 100644
--- a/drivers/platform/x86/intel/ifs/runtest.c
+++ b/drivers/platform/x86/intel/ifs/runtest.c
@@ -176,7 +176,7 @@ static int doscan(void *data)
wrmsrl(MSR_ACTIVATE_SCAN, params->activate->data);
rdmsrl(MSR_SCAN_STATUS, status.data);
- trace_ifs_status(start, stop, status.data);
+ trace_ifs_status(ifsd->cur_batch, start, stop, status.data);
/* Pass back the result of the scan */
if (cpu == first)
--
2.39.2
next prev parent reply other threads:[~2024-01-25 8:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-25 8:22 [PATCH 0/5] Miscelleanous fixes and improvements to Infield Scan Ashok Raj
2024-01-25 8:22 ` [PATCH 1/5] platform/x86/intel/ifs: Call release_firmware() when handling errors Ashok Raj
2024-01-25 13:04 ` Ilpo Järvinen
2024-01-26 19:15 ` Hans de Goede
2024-01-29 3:55 ` Pengfei Xu
2024-01-29 8:39 ` Hans de Goede
2024-01-25 8:22 ` [PATCH 2/5] platform/x86/intel/ifs: Trace on all HT threads when executing a test Ashok Raj
2024-01-25 8:22 ` Ashok Raj [this message]
2024-01-25 8:22 ` [PATCH 4/5] platform/x86/intel/ifs: Replace the exit rendezvous with an entry rendezvous for ARRAY_BIST Ashok Raj
2024-01-25 8:22 ` [PATCH 5/5] platform/x86/intel/ifs: Add an entry rendezvous for SAF Ashok Raj
2024-01-31 10:29 ` [PATCH 0/5] Miscelleanous fixes and improvements to Infield Scan Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240125082254.424859-4-ashok.raj@intel.com \
--to=ashok.raj@intel.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jithu.joseph@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=patches@lists.linux.dev \
--cc=pengfei.xu@intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox