Re: [PATCH] s390: vDSO: Drop '-fPIC' from LDFLAGS

[Heiko Carstens <hca@linux.ibm.com>]

On Tue, Jan 30, 2024 at 08:14:28PM -0700, Nathan Chancellor wrote:
> '-fPIC' as an option to the linker does not do what it seems like it
> should. With ld.bfd, it is treated as '-f PIC', which does not make
> sense based on the meaning of '-f':
> 
>   -f SHLIB, --auxiliary SHLIB Auxiliary filter for shared object symbol table
> 
> When building with ld.lld (currently under review in a GitHub pull
> request), it just errors out because '-f' means nothing and neither does
> '-fPIC':
> 
>   ld.lld: error: unknown argument '-fPIC'
> 
> '-fPIC' was blindly copied from CFLAGS when the vDSO stopped being
> linked with '$(CC)', it should not be needed. Remove it to clear up the
> build failure with ld.lld.
> 
> Fixes: 2b2a25845d53 ("s390/vdso: Use $(LD) instead of $(CC) to link vDSO")
> Link: https://github.com/llvm/llvm-project/pull/75643
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>

Applied.

> Hi all,
> 
> The LLVM folks are working on SystemZ support in ld.lld and this issue
> came up from my initial testing. There are also some other issues that I
> have come across in testing that I note in the GitHub pull request
> linked above. If they seem like kernel issues, any expertise or help
> would be greatly appreciated towards getting this working.

This is great news! Please feel free to involve us at any time.
We will do our best to help if possible.