From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0F77A93C; Tue, 13 Feb 2024 17:40:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707846006; cv=none; b=kdb16gXfGaSM4qPrZvVI4MsHVcG6PR2y/SMfExwveBpwvOMQt2EYUE69N2ER2OO7Ka0yu84SevVcH65Vqf5eae1TMlV7BZMz34M/tMd68scNthC049HFofmekF69+T08GXDH8HHRjhSqhDSYQUl8rna7M3N+E2bqZY1vbDAtSi0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707846006; c=relaxed/simple; bh=mFtrG8GZHrodFn4Z5XCJJZ2Ba0JJMEKQzBr/ZTlTAAY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Lu6GcF1A2A1vrqaZ2kDY6Q69FplH8WHsXFKaNXejHT4Ae4SIahye4XoobJMQE05/N5sSkmcwvTgU/wyz9T2f0NsV7H7RAqJ9Yh5IkuhmvarhcHqlMTPWPmk5CTlxrpEI0xDE1d21ghfi+JCwLGbK4TTglhEOAGDzKjEG1VxJdCg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=jxa1LEg0; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="jxa1LEg0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 45517C433C7; Tue, 13 Feb 2024 17:40:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1707846005; bh=mFtrG8GZHrodFn4Z5XCJJZ2Ba0JJMEKQzBr/ZTlTAAY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jxa1LEg0HD7mIsGBMo8ARPH8hoqklA/0wM/AbJl0L4JPdD0TpjcapM+BhhjFRT81W w9OKhPZQm9xDsRT05Yc8gQIS7m/GBxAhSfx6gj5cZd3PyvWd1K35A5FG/SutG756eY igqv5N+jkLs14if0IgmR7iV6sXduZBRswHSXOkJA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Sean Young , Takashi Iwai Subject: [PATCH 6.7 089/124] ALSA: usb-audio: add quirk for RODE NT-USB+ Date: Tue, 13 Feb 2024 18:21:51 +0100 Message-ID: <20240213171856.332656756@linuxfoundation.org> X-Mailer: git-send-email 2.43.1 In-Reply-To: <20240213171853.722912593@linuxfoundation.org> References: <20240213171853.722912593@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 6.7-stable review patch. If anyone has any objections, please let me know. ------------------ From: Sean Young commit 7822baa844a87cbb93308c1032c3d47d4079bb8a upstream. The RODE NT-USB+ is marketed as a professional usb microphone, however the usb audio interface is a mess: [ 1.130977] usb 1-5: new full-speed USB device number 2 using xhci_hcd [ 1.503906] usb 1-5: config 1 has an invalid interface number: 5 but max is 4 [ 1.503912] usb 1-5: config 1 has no interface number 4 [ 1.519689] usb 1-5: New USB device found, idVendor=19f7, idProduct=0035, bcdDevice= 1.09 [ 1.519695] usb 1-5: New USB device strings: Mfr=1, Product=2, SerialNumber=3 [ 1.519697] usb 1-5: Product: RØDE NT-USB+ [ 1.519699] usb 1-5: Manufacturer: RØDE [ 1.519700] usb 1-5: SerialNumber: 1D773A1A [ 8.327495] usb 1-5: 1:1: cannot get freq at ep 0x82 [ 8.344500] usb 1-5: 1:2: cannot get freq at ep 0x82 [ 8.365499] usb 1-5: 2:1: cannot get freq at ep 0x2 Add QUIRK_FLAG_GET_SAMPLE_RATE to work around the broken sample rate get. I have asked Rode support to fix it, but they show no interest. Signed-off-by: Sean Young Cc: Link: https://lore.kernel.org/r/20240124151524.23314-1-sean@mess.org Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/usb/quirks.c | 2 ++ 1 file changed, 2 insertions(+) --- a/sound/usb/quirks.c +++ b/sound/usb/quirks.c @@ -2183,6 +2183,8 @@ static const struct usb_audio_quirk_flag QUIRK_FLAG_FIXED_RATE), DEVICE_FLG(0x1bcf, 0x2283, /* NexiGo N930AF FHD Webcam */ QUIRK_FLAG_GET_SAMPLE_RATE), + DEVICE_FLG(0x19f7, 0x0035, /* RODE NT-USB+ */ + QUIRK_FLAG_GET_SAMPLE_RATE), /* Vendor matches */ VENDOR_FLG(0x045e, /* MS Lifecam */