* [PATCH] s390: Don't allow CONFIG_COMPAT with LD=ld.lld
@ 2024-02-14 22:53 Nathan Chancellor
2024-02-15 8:51 ` Heiko Carstens
0 siblings, 1 reply; 2+ messages in thread
From: Nathan Chancellor @ 2024-02-14 22:53 UTC (permalink / raw)
To: hca, gor, agordeev
Cc: borntraeger, svens, morbo, justinstitt, linux-s390, llvm, patches,
Nathan Chancellor
When building 'ARCH=s390 defconfig compat.config' with GCC and
LD=ld.lld, there is an error when attempting to link the compat vDSO:
ld.lld: error: unknown emulation: elf_s390
make[4]: *** [arch/s390/kernel/vdso32/Makefile:48: arch/s390/kernel/vdso32/vdso32.so.dbg] Error 1
Much like clang, ld.lld only supports the 64-bit s390 emulation. Add a
dependency on not using LLD to CONFIG_COMPAT to avoid breaking the build
with this toolchain combination.
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
---
arch/s390/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig
index 771235aee6bf..39e937309fc2 100644
--- a/arch/s390/Kconfig
+++ b/arch/s390/Kconfig
@@ -449,7 +449,7 @@ config COMPAT
select COMPAT_OLD_SIGACTION
select HAVE_UID16
depends on MULTIUSER
- depends on !CC_IS_CLANG
+ depends on !CC_IS_CLANG && !LD_IS_LLD
help
Select this option if you want to enable your system kernel to
handle system-calls from ELF binaries for 31 bit ESA. This option
---
base-commit: 616c4ea9bce426aa6efd6dc333bdd479ce352df0
change-id: 20240214-s390-compat-lld-dep-875a6c94be75
Best regards,
--
Nathan Chancellor <nathan@kernel.org>
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] s390: Don't allow CONFIG_COMPAT with LD=ld.lld
2024-02-14 22:53 [PATCH] s390: Don't allow CONFIG_COMPAT with LD=ld.lld Nathan Chancellor
@ 2024-02-15 8:51 ` Heiko Carstens
0 siblings, 0 replies; 2+ messages in thread
From: Heiko Carstens @ 2024-02-15 8:51 UTC (permalink / raw)
To: Nathan Chancellor
Cc: gor, agordeev, borntraeger, svens, morbo, justinstitt, linux-s390,
llvm, patches
On Wed, Feb 14, 2024 at 03:53:48PM -0700, Nathan Chancellor wrote:
> When building 'ARCH=s390 defconfig compat.config' with GCC and
> LD=ld.lld, there is an error when attempting to link the compat vDSO:
>
> ld.lld: error: unknown emulation: elf_s390
> make[4]: *** [arch/s390/kernel/vdso32/Makefile:48: arch/s390/kernel/vdso32/vdso32.so.dbg] Error 1
>
> Much like clang, ld.lld only supports the 64-bit s390 emulation. Add a
> dependency on not using LLD to CONFIG_COMPAT to avoid breaking the build
> with this toolchain combination.
>
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> ---
> arch/s390/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-02-15 8:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-14 22:53 [PATCH] s390: Don't allow CONFIG_COMPAT with LD=ld.lld Nathan Chancellor
2024-02-15 8:51 ` Heiko Carstens
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).