From: Jason Gunthorpe <jgg@nvidia.com>
To: Daniel Mentz <danielmentz@google.com>
Cc: iommu@lists.linux.dev, Joerg Roedel <joro@8bytes.org>,
linux-arm-kernel@lists.infradead.org,
Robin Murphy <robin.murphy@arm.com>,
Will Deacon <will@kernel.org>, Eric Auger <eric.auger@redhat.com>,
Jean-Philippe Brucker <jean-philippe@linaro.org>,
Moritz Fischer <mdf@kernel.org>,
Michael Shavit <mshavit@google.com>,
Nicolin Chen <nicolinc@nvidia.com>,
patches@lists.linux.dev,
Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>
Subject: Re: [PATCH v4 20/27] iommu: Add ops->domain_alloc_sva()
Date: Tue, 20 Feb 2024 10:09:39 -0400 [thread overview]
Message-ID: <20240220140939.GN13330@nvidia.com> (raw)
In-Reply-To: <CAE2F3rBip7oe4ip-kK5GR6+nY_efsVrrxcxv=4m4_aWGKOg=gw@mail.gmail.com>
On Mon, Feb 19, 2024 at 02:47:31PM -0800, Daniel Mentz wrote:
> On Fri, Jan 26, 2024 at 10:15 AM Jason Gunthorpe <jgg@nvidia.com> wrote:
> > --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3-sva.c
> > +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3-sva.c
> > @@ -654,7 +654,7 @@ static int arm_smmu_sva_set_dev_pasid(struct iommu_domain *domain,
> >
> > static void arm_smmu_sva_domain_free(struct iommu_domain *domain)
> > {
> > - kfree(domain);
> > + kfree(to_smmu_domain(domain));
> > }
>
> I'm wondering if this particular change belongs into the other change
> with title "iommu/arm-smmu-v3: Make SVA allocate a normal
> arm_smmu_domain"
Yes, you are right. I think it is a rebasing error..
Thanks,
Jason
next prev parent reply other threads:[~2024-02-20 14:09 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-26 18:15 [PATCH v4 00/27] Update SMMUv3 to the modern iommu API (part 2/3) Jason Gunthorpe
2024-01-26 18:15 ` [PATCH v4 01/27] iommu/arm-smmu-v3: Check that the RID domain is S1 in SVA Jason Gunthorpe
2024-01-30 8:46 ` Shameerali Kolothum Thodi
2024-01-30 16:04 ` Jason Gunthorpe
2024-01-30 17:11 ` Shameerali Kolothum Thodi
2024-01-30 19:03 ` Jason Gunthorpe
2024-01-26 18:15 ` [PATCH v4 02/27] iommu/arm-smmu-v3: Do not allow a SVA domain to be set on the wrong PASID Jason Gunthorpe
2024-01-26 18:15 ` [PATCH v4 03/27] iommu/arm-smmu-v3: Do not ATC invalidate the entire domain Jason Gunthorpe
2024-01-26 18:15 ` [PATCH v4 04/27] iommu/arm-smmu-v3: Add a type for the CD entry Jason Gunthorpe
2024-01-26 18:15 ` [PATCH v4 05/27] iommu/arm-smmu-v3: Make CD programming use arm_smmu_write_entry() Jason Gunthorpe
2024-01-26 18:15 ` [PATCH v4 06/27] iommu/arm-smmu-v3: Consolidate clearing a CD table entry Jason Gunthorpe
2024-01-26 18:15 ` [PATCH v4 07/27] iommu/arm-smmu-v3: Move the CD generation for S1 domains into a function Jason Gunthorpe
2024-01-26 18:15 ` [PATCH v4 08/27] iommu/arm-smmu-v3: Move allocation of the cdtable into arm_smmu_get_cd_ptr() Jason Gunthorpe
2024-01-26 18:15 ` [PATCH v4 09/27] iommu/arm-smmu-v3: Allocate the CD table entry in advance Jason Gunthorpe
2024-01-26 18:15 ` [PATCH v4 10/27] iommu/arm-smmu-v3: Move the CD generation for SVA into a function Jason Gunthorpe
2024-01-26 18:15 ` [PATCH v4 11/27] iommu/arm-smmu-v3: Lift CD programming out of the SVA notifier code Jason Gunthorpe
2024-01-26 18:15 ` [PATCH v4 12/27] iommu/arm-smmu-v3: Build the whole CD in arm_smmu_make_s1_cd() Jason Gunthorpe
2024-01-26 18:15 ` [PATCH v4 13/27] iommu/arm-smmu-v3: Make smmu_domain->devices into an allocated list Jason Gunthorpe
2024-01-26 18:15 ` [PATCH v4 14/27] iommu/arm-smmu-v3: Make changing domains be hitless for ATS Jason Gunthorpe
2024-01-31 11:20 ` Shameerali Kolothum Thodi
2024-01-31 14:12 ` Jason Gunthorpe
2024-01-31 14:29 ` Shameerali Kolothum Thodi
2024-01-26 18:15 ` [PATCH v4 15/27] iommu/arm-smmu-v3: Add ssid to struct arm_smmu_master_domain Jason Gunthorpe
2024-01-26 18:15 ` [PATCH v4 16/27] iommu/arm-smmu-v3: Keep track of valid CD entries in the cd_table Jason Gunthorpe
2024-01-26 18:15 ` [PATCH v4 17/27] iommu/arm-smmu-v3: Thread SSID through the arm_smmu_attach_*() interface Jason Gunthorpe
2024-01-26 18:15 ` [PATCH v4 18/27] iommu/arm-smmu-v3: Make SVA allocate a normal arm_smmu_domain Jason Gunthorpe
2024-01-26 18:15 ` [PATCH v4 19/27] iommu/arm-smmu-v3: Keep track of arm_smmu_master_domain for SVA Jason Gunthorpe
2024-01-26 18:15 ` [PATCH v4 20/27] iommu: Add ops->domain_alloc_sva() Jason Gunthorpe
2024-02-19 22:47 ` Daniel Mentz
2024-02-20 14:09 ` Jason Gunthorpe [this message]
2024-01-26 18:15 ` [PATCH v4 21/27] iommu/arm-smmu-v3: Put the SVA mmu notifier in the smmu_domain Jason Gunthorpe
2024-01-26 18:15 ` [PATCH v4 22/27] iommu/arm-smmu-v3: Consolidate freeing the ASID/VMID Jason Gunthorpe
2024-01-26 18:15 ` [PATCH v4 23/27] iommu/arm-smmu-v3: Move the arm_smmu_asid_xa to per-smmu like vmid Jason Gunthorpe
2024-01-26 18:15 ` [PATCH v4 24/27] iommu/arm-smmu-v3: Bring back SVA BTM support Jason Gunthorpe
2024-01-26 18:15 ` [PATCH v4 25/27] iommu/arm-smmu-v3: Allow IDENTITY/BLOCKED to be set while PASID is used Jason Gunthorpe
2024-01-26 18:15 ` [PATCH v4 26/27] iommu/arm-smmu-v3: Allow a PASID to be set when RID is IDENTITY/BLOCKED Jason Gunthorpe
2024-01-26 18:15 ` [PATCH v4 27/27] iommu/arm-smmu-v3: Allow setting a S1 domain to a PASID Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240220140939.GN13330@nvidia.com \
--to=jgg@nvidia.com \
--cc=danielmentz@google.com \
--cc=eric.auger@redhat.com \
--cc=iommu@lists.linux.dev \
--cc=jean-philippe@linaro.org \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mdf@kernel.org \
--cc=mshavit@google.com \
--cc=nicolinc@nvidia.com \
--cc=patches@lists.linux.dev \
--cc=robin.murphy@arm.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).