From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5010A151CCC; Tue, 20 Feb 2024 21:36:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708464992; cv=none; b=ZaI1/xt53AfHQpeafPRLsxgzBHT1Ucw9QPHPuA1Ng22EfOjB20zfGW42hlrX/YDgt8sCvuqCCZ8q2WwnNa52sFuxkgzoMiJzf8iwihFphgd+ihpuzstiRh9kCLsABMfPlcWHd4djKFUXm4p+kFw19lt5jG085EJuGDG1iSbsDIc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708464992; c=relaxed/simple; bh=DCtFTVrKil1hvM0E+ZWtwyhf6cWlvKKmRjHBZZ1wrms=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SpykpAddDnN0coOEsx/GJLZwtL72yG+t9+ZVzNXHGtV31S894YxaRZE1+zcDp2GEK6y1HlUShhdGNm8DltH93Nvk9y24o1yIrrLtY1xZkYlpecRheqpZVhpuyioWERAsiw0viWHwvgCBeusUuPiftS1Opyj2pIjmb62BAvArObM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=14hqI0oD; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="14hqI0oD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BB663C433C7; Tue, 20 Feb 2024 21:36:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1708464992; bh=DCtFTVrKil1hvM0E+ZWtwyhf6cWlvKKmRjHBZZ1wrms=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=14hqI0oD1fseHj+i8d4uBTLyA4yx+XDkSrjbyKySFsFNFBGaiRNU/mqu60BGX5N5K tIbhcBFDuy2vyzTHYd3GxefFj9a82cvLpGjvV6Qre2cQWU/eSj5erX/fdV12xJjsAj bGad/dNGbNo7Mi69ZK0KrrExAmG/Xjz9/g9MUUdc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Fedor Pchelkin , Namjae Jeon , Steve French Subject: [PATCH 6.7 202/309] ksmbd: free aux buffer if ksmbd_iov_pin_rsp_read fails Date: Tue, 20 Feb 2024 21:56:01 +0100 Message-ID: <20240220205639.512354966@linuxfoundation.org> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20240220205633.096363225@linuxfoundation.org> References: <20240220205633.096363225@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.7-stable review patch. If anyone has any objections, please let me know. ------------------ From: Fedor Pchelkin commit 108a020c64434fed4b69762879d78cd24088b4c7 upstream. ksmbd_iov_pin_rsp_read() doesn't free the provided aux buffer if it fails. Seems to be the caller's responsibility to clear the buffer in error case. Found by Linux Verification Center (linuxtesting.org). Fixes: e2b76ab8b5c9 ("ksmbd: add support for read compound") Cc: stable@vger.kernel.org Signed-off-by: Fedor Pchelkin Acked-by: Namjae Jeon Signed-off-by: Steve French Signed-off-by: Greg Kroah-Hartman --- fs/smb/server/smb2pdu.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) --- a/fs/smb/server/smb2pdu.c +++ b/fs/smb/server/smb2pdu.c @@ -6173,8 +6173,10 @@ static noinline int smb2_read_pipe(struc err = ksmbd_iov_pin_rsp_read(work, (void *)rsp, offsetof(struct smb2_read_rsp, Buffer), aux_payload_buf, nbytes); - if (err) + if (err) { + kvfree(aux_payload_buf); goto out; + } kvfree(rpc_resp); } else { err = ksmbd_iov_pin_rsp(work, (void *)rsp, @@ -6384,8 +6386,10 @@ int smb2_read(struct ksmbd_work *work) err = ksmbd_iov_pin_rsp_read(work, (void *)rsp, offsetof(struct smb2_read_rsp, Buffer), aux_payload_buf, nbytes); - if (err) + if (err) { + kvfree(aux_payload_buf); goto out; + } ksmbd_fd_put(work, fp); return 0;