From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B7322DF9F; Tue, 20 Feb 2024 21:21:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708464107; cv=none; b=SDqESkO3hrZ9n/NAMqUgt5G7jdoK6joWD98TpuSyUIZHq757GoDGSwCZj1jmMSka9UVoly9QdQ0fTVoYhdyVHYv383fVzqki6bBGZ2NETfqxhOhZ+ArooYuIfjGasIr2clT4grdC3+vn5OFZ3dNMG7grrP+AVJ0okoCvQx7u9eU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708464107; c=relaxed/simple; bh=BDbTMsGW10G6GMNLVRr6lbkrVzPPZEJbaTlydkhEFyI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bmJjhYfUNpeF8Ylkl6h/DmLlncJieAKqRpLviH8zfx5zLMTFZK40xeWAq+v0wO0QqGXSnPTPdd+aY//NHoHmef1361OPJZOHQR0om1BWUFamLH+NRWPeXfohfxWvLg+Kq6vVXxTI3IloKpGaK8PSp8Mg67Xn9cUdaU++/Mv+A88= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=pmcpfV+W; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="pmcpfV+W" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C7109C433F1; Tue, 20 Feb 2024 21:21:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1708464107; bh=BDbTMsGW10G6GMNLVRr6lbkrVzPPZEJbaTlydkhEFyI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pmcpfV+W3GcJfRBxR5chSaXnBndAn9lcqkeKusRrcHuSxUcjz8/pgq8QUL1IrPV2C nHqKpsrt6zdjCfFn9U61XtKVxpwsgY2rFnyQV6VilChZqt7+E0P3xYjidMfWIQyyo8 mdMtFprH5eK6ESWwpHbMnUkfQlh9z6lfZxDdpTfw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, stable@kernel.vger.org, Damien Le Moal , Christoph Hellwig , Johannes Thumshirn , Hannes Reinecke , Jens Axboe , Sasha Levin Subject: [PATCH 6.6 254/331] block: fix partial zone append completion handling in req_bio_endio() Date: Tue, 20 Feb 2024 21:56:10 +0100 Message-ID: <20240220205645.834026777@linuxfoundation.org> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20240220205637.572693592@linuxfoundation.org> References: <20240220205637.572693592@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Damien Le Moal [ Upstream commit 748dc0b65ec2b4b7b3dbd7befcc4a54fdcac7988 ] Partial completions of zone append request is not allowed but if a zone append completion indicates a number of completed bytes different from the original BIO size, only the BIO status is set to error. This leads to bio_advance() not setting the BIO size to 0 and thus to not call bio_endio() at the end of req_bio_endio(). Make sure a partially completed zone append is failed and completed immediately by forcing the completed number of bytes (nbytes) to be equal to the BIO size, thus ensuring that bio_endio() is called. Fixes: 297db731847e ("block: fix req_bio_endio append error handling") Cc: stable@kernel.vger.org Signed-off-by: Damien Le Moal Reviewed-by: Christoph Hellwig Reviewed-by: Johannes Thumshirn Reviewed-by: Hannes Reinecke Link: https://lore.kernel.org/r/20240110092942.442334-1-dlemoal@kernel.org Signed-off-by: Jens Axboe Signed-off-by: Sasha Levin --- block/blk-mq.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/block/blk-mq.c b/block/blk-mq.c index 257b0addd47e..d8b47f534df9 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -767,11 +767,16 @@ static void req_bio_endio(struct request *rq, struct bio *bio, /* * Partial zone append completions cannot be supported as the * BIO fragments may end up not being written sequentially. + * For such case, force the completed nbytes to be equal to + * the BIO size so that bio_advance() sets the BIO remaining + * size to 0 and we end up calling bio_endio() before returning. */ - if (bio->bi_iter.bi_size != nbytes) + if (bio->bi_iter.bi_size != nbytes) { bio->bi_status = BLK_STS_IOERR; - else + nbytes = bio->bi_iter.bi_size; + } else { bio->bi_iter.bi_sector = rq->__sector; + } } bio_advance(bio, nbytes); -- 2.43.0