From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E591653816; Wed, 21 Feb 2024 13:13:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708521188; cv=none; b=m1A/d7u22RA8duUxBcZmS2izmnPHZ79aGhz6HofdHJGvG9Kcm+ICkZ3vGURhP0rdBF3b+RCnnJBwWec+gSYPkd66fGQ4NsTv4j+ILSrQyAjdBvjPfnNAPvs05t9SAgbXdRrTWLlYdw/VnCskVVxmt9YFk82lbpM5MeWRsmEsFVM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708521188; c=relaxed/simple; bh=ieUGH5NV2oyaxTqc5hA+dpBMa+kaeBKqhjYobkQIESU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=e3S/Lg3ZlUKzb3nX6K/WjalXMvjcsh0+7t2hwp8BZ2Dt5R1tor/M9dNQ9fDdl9wi2ZSX3o/CGuHfVxatqM/9F5Rm5XbEFh6wUWP83N0hdwtnShFRlkDvIiLQIwclKsmWk9ZUZXt5oiJakOT3yPsljEglIGnGtu3ri5p3YW3baA0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=iY1VOzwV; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="iY1VOzwV" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6BD6EC433C7; Wed, 21 Feb 2024 13:13:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1708521187; bh=ieUGH5NV2oyaxTqc5hA+dpBMa+kaeBKqhjYobkQIESU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iY1VOzwVSU/7kX3qltgXP/+nNYA8R/S7rScdgVXPTzYwWz01LIUolcLtIHFUyTmNq VnBNzFlT+KEkKNyPASmW3gqnVuoFrbzLkdUT9ksCHuwDN1f5i+UvMpbiLaLfQKfdte O00xz4uzrrc2fNZOmHu2TeFFHFsGy8wfFVWydeo4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Neil Armstrong , Dan Carpenter , Robert Foss Subject: [PATCH 4.19 043/202] drm/bridge: nxp-ptn3460: simplify some error checking Date: Wed, 21 Feb 2024 14:05:44 +0100 Message-ID: <20240221125933.188622033@linuxfoundation.org> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20240221125931.742034354@linuxfoundation.org> References: <20240221125931.742034354@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Dan Carpenter commit 28d3d0696688154cc04983f343011d07bf0508e4 upstream. The i2c_master_send/recv() functions return negative error codes or they return "len" on success. So the error handling here can be written as just normal checks for "if (ret < 0) return ret;". No need to complicate things. Btw, in this code the "len" parameter can never be zero, but even if it were, then I feel like this would still be the best way to write it. Fixes: 914437992876 ("drm/bridge: nxp-ptn3460: fix i2c_master_send() error checking") Suggested-by: Neil Armstrong Signed-off-by: Dan Carpenter Reviewed-by: Robert Foss Signed-off-by: Robert Foss Link: https://patchwork.freedesktop.org/patch/msgid/04242630-42d8-4920-8c67-24ac9db6b3c9@moroto.mountain Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/bridge/nxp-ptn3460.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) --- a/drivers/gpu/drm/bridge/nxp-ptn3460.c +++ b/drivers/gpu/drm/bridge/nxp-ptn3460.c @@ -64,15 +64,15 @@ static int ptn3460_read_bytes(struct ptn int ret; ret = i2c_master_send(ptn_bridge->client, &addr, 1); - if (ret <= 0) { + if (ret < 0) { DRM_ERROR("Failed to send i2c command, ret=%d\n", ret); - return ret ?: -EIO; + return ret; } ret = i2c_master_recv(ptn_bridge->client, buf, len); - if (ret != len) { + if (ret < 0) { DRM_ERROR("Failed to recv i2c data, ret=%d\n", ret); - return ret < 0 ? ret : -EIO; + return ret; } return 0; @@ -88,9 +88,9 @@ static int ptn3460_write_byte(struct ptn buf[1] = val; ret = i2c_master_send(ptn_bridge->client, buf, ARRAY_SIZE(buf)); - if (ret != ARRAY_SIZE(buf)) { + if (ret < 0) { DRM_ERROR("Failed to send i2c command, ret=%d\n", ret); - return ret < 0 ? ret : -EIO; + return ret; } return 0;