From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7271C3FB21; Wed, 21 Feb 2024 13:19:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708521551; cv=none; b=tGelUNJoAmGSSvMHLENVgG5VXDEqLbYkOqNcDlGWQ2ajVRlm49/RIhTtLmx4HMOWFYJqilcO+a7Q/q/3AuOglsqrVgiTR2e1833Yafd1dCDa1A60uo6lm3DAJ8o9BVw1aXN10dQo30zBGqk0uHVz1VSJYuW/agdlJJcZsEw3sOA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708521551; c=relaxed/simple; bh=XVo0XqrrB3wJCeQ7WAru9cZbVWvvCV0K53sTFVR6TL4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=X4dgdf0vE2LFkEKUqpUnHSjVZbJzyXU987xZEPcXq1ee+bmb1UjJ+jv0DuLmua02d/GzqU2S8d7JMTQdkjZihUmvAaKltaA78JrIg7qySMbukvslcvUS04rqjQVqtuXWKHDUr10md+vdR8DJqz9Wx19pvOycEwBQX92oAx05xdA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=PdMVbgeE; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="PdMVbgeE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D3C79C433C7; Wed, 21 Feb 2024 13:19:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1708521551; bh=XVo0XqrrB3wJCeQ7WAru9cZbVWvvCV0K53sTFVR6TL4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PdMVbgeE/yp1MAjKVc6wnN8sZ3n3omtt4ybX8dbn+h1r6/VrhBFqAoRI9dYB8QSRl pXqxp2fxKgImYK0YlfOJyw22kpP/PktLpgXOid1XW+jj036v/pJRdgdxkh6t9VuMnP VXNGLM2614MtzxX/Qo0LZnnM+GPIZv1kE7zrg9iY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Kuan-Wei Chiu , Stephen Boyd , Sasha Levin Subject: [PATCH 4.19 112/202] clk: mmp: pxa168: Fix memory leak in pxa168_clk_init() Date: Wed, 21 Feb 2024 14:06:53 +0100 Message-ID: <20240221125935.361570474@linuxfoundation.org> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20240221125931.742034354@linuxfoundation.org> References: <20240221125931.742034354@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Kuan-Wei Chiu [ Upstream commit 2fbabea626b6467eb4e6c4cb7a16523da12e43b4 ] In cases where mapping of mpmu/apmu/apbc registers fails, the code path does not handle the failure gracefully, potentially leading to a memory leak. This fix ensures proper cleanup by freeing the allocated memory for 'pxa_unit' before returning. Signed-off-by: Kuan-Wei Chiu Link: https://lore.kernel.org/r/20231210175232.3414584-1-visitorckw@gmail.com Signed-off-by: Stephen Boyd Signed-off-by: Sasha Levin --- drivers/clk/mmp/clk-of-pxa168.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/clk/mmp/clk-of-pxa168.c b/drivers/clk/mmp/clk-of-pxa168.c index f110c02e83cb..9674c6c06dca 100644 --- a/drivers/clk/mmp/clk-of-pxa168.c +++ b/drivers/clk/mmp/clk-of-pxa168.c @@ -258,18 +258,21 @@ static void __init pxa168_clk_init(struct device_node *np) pxa_unit->mpmu_base = of_iomap(np, 0); if (!pxa_unit->mpmu_base) { pr_err("failed to map mpmu registers\n"); + kfree(pxa_unit); return; } pxa_unit->apmu_base = of_iomap(np, 1); if (!pxa_unit->apmu_base) { pr_err("failed to map apmu registers\n"); + kfree(pxa_unit); return; } pxa_unit->apbc_base = of_iomap(np, 2); if (!pxa_unit->apbc_base) { pr_err("failed to map apbc registers\n"); + kfree(pxa_unit); return; } -- 2.43.0