From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9A2569DF9; Wed, 21 Feb 2024 13:19:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708521560; cv=none; b=H2blA+AhjO1C1eLZH5IybOTPcM/ZpwJtncdZGLKjMR0Df/LtO4qDJWcMuY9Wpcuc+NhyspaNYl/aq/UHyHMQRxNDJjue6KKs5Zte/FEAuzyqSvvJPzLTARqMQcZlNwU9aO1YMUFWEmXUgbPdvmgx+1AsAeibNakN7YnOKvYlbcQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708521560; c=relaxed/simple; bh=x2TgDEql2aGdm0N4Tq4w2FYoAheA2JlsI867O1BMIEo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=NYwsQl4JMdMF9IRvnt1Mjwwov2AQVED23ob7QftC0xtlFv6fNIbXMZ2JUczkg3sY2JaoBMD4WBZFDa8ChQKQP/Q2VF+iDdEUm8062cNdZSkg9J31i3CHXssKH2INDnu5mv+n1x/qzf5syA3wZ2CGgG5ssIff9MnmtMzteWMaY5k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=crz2J7Tm; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="crz2J7Tm" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 464F7C43394; Wed, 21 Feb 2024 13:19:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1708521560; bh=x2TgDEql2aGdm0N4Tq4w2FYoAheA2JlsI867O1BMIEo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=crz2J7Tmoxksk55z0d8FMBgZjppUV+mzP+fryLVzEQetFZvm1uUh1GAa0aefChU44 cFcpty/KnU6txyaddhHStN3qLK3J7Iy0f72llwGcR957bGV0MYVXB09AZDzGjwwITL SlC5b8uvDE3EGFj6jYCGPa3pDrok7dtSZwu2CmTk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Felix Kuehling , =?UTF-8?q?Christian=20K=C3=B6nig?= , Alex Deucher , Srinivasan Shanmugam , Felix Kuehling , Sasha Levin Subject: [PATCH 4.19 115/202] drm/amdgpu: Drop fence check in to_amdgpu_amdkfd_fence() Date: Wed, 21 Feb 2024 14:06:56 +0100 Message-ID: <20240221125935.450972205@linuxfoundation.org> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20240221125931.742034354@linuxfoundation.org> References: <20240221125931.742034354@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Srinivasan Shanmugam [ Upstream commit bf2ad4fb8adca89374b54b225d494e0b1956dbea ] Return value of container_of(...) can't be null, so null check is not required for 'fence'. Hence drop its NULL check. Fixes the below: drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_fence.c:93 to_amdgpu_amdkfd_fence() warn: can 'fence' even be NULL? Cc: Felix Kuehling Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam Reviewed-by: Felix Kuehling Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_fence.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_fence.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_fence.c index 574c1181ae9a..75e4f1abb4c9 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_fence.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_fence.c @@ -88,7 +88,7 @@ struct amdgpu_amdkfd_fence *to_amdgpu_amdkfd_fence(struct dma_fence *f) return NULL; fence = container_of(f, struct amdgpu_amdkfd_fence, base); - if (fence && f->ops == &amdkfd_fence_ops) + if (f->ops == &amdkfd_fence_ops) return fence; return NULL; -- 2.43.0