From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D81333D981; Wed, 21 Feb 2024 14:17:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708525059; cv=none; b=jnadcEhm2pZsL9VYLSDAwo8vq9d2Qh7L0wR3y9WvQDCcnkN+ow33zkmoK3pS308BFbl1NG3RAHxtHJvUflU68RaldKoTj4GLaR96zgURyNa2CCqJINJnOaf6gODWqyBwV0nn5jLqgdDPLyiUMyx3FOHdiAI0WzcAZmiopbRuN8c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708525059; c=relaxed/simple; bh=DbUCl7Da1v6+hxfh9OtbI5bkuIKTn08mEMXRSDN60lQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nx6YHq+t5w8AMtmk0qnpRRGRL7zPc6IZZZ6pnYIT6WOeXFzFHLDU6OpPlb3hUPy+pH4RNBtIttIyNiBiQYFwC7qZ7p7xKE1/ikP5NBYjAaEIp36UBtE43vJKHg5JbpYuuOrB3iVVEJAPGa5g/fIQlQ9YcXoSRd5EVXeYDb76vck= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=tocY1OnR; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="tocY1OnR" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 10E62C433C7; Wed, 21 Feb 2024 14:17:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1708525059; bh=DbUCl7Da1v6+hxfh9OtbI5bkuIKTn08mEMXRSDN60lQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tocY1OnRw8HOy3/072tKr/6Bjo2Mq5M8cu5lWZcCMnOeAxajL2sIkzvhty5OteOnF June7fGmLTDg+51CneKZU25JeqE5eYopnWkr2NciSvWmYxfhUz8+byGPcLEMV+bIaP hMmIBBSZ+YY7AgclvEkCw7JndI797Uc9+cOdTMF8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Shenwei Wang , Paolo Abeni , Sasha Levin Subject: [PATCH 5.4 041/267] net: fec: fix the unhandled context fault from smmu Date: Wed, 21 Feb 2024 14:06:22 +0100 Message-ID: <20240221125941.308541156@linuxfoundation.org> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20240221125940.058369148@linuxfoundation.org> References: <20240221125940.058369148@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Shenwei Wang [ Upstream commit 5e344807735023cd3a67c37a1852b849caa42620 ] When repeatedly changing the interface link speed using the command below: ethtool -s eth0 speed 100 duplex full ethtool -s eth0 speed 1000 duplex full The following errors may sometimes be reported by the ARM SMMU driver: [ 5395.035364] fec 5b040000.ethernet eth0: Link is Down [ 5395.039255] arm-smmu 51400000.iommu: Unhandled context fault: fsr=0x402, iova=0x00000000, fsynr=0x100001, cbfrsynra=0x852, cb=2 [ 5398.108460] fec 5b040000.ethernet eth0: Link is Up - 100Mbps/Full - flow control off It is identified that the FEC driver does not properly stop the TX queue during the link speed transitions, and this results in the invalid virtual I/O address translations from the SMMU and causes the context faults. Fixes: dbc64a8ea231 ("net: fec: move calls to quiesce/resume packet processing out of fec_restart()") Signed-off-by: Shenwei Wang Link: https://lore.kernel.org/r/20240123165141.2008104-1-shenwei.wang@nxp.com Signed-off-by: Paolo Abeni Signed-off-by: Sasha Levin --- drivers/net/ethernet/freescale/fec_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index f67f104049db..b55d6ed9aa13 100644 --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -1795,6 +1795,7 @@ static void fec_enet_adjust_link(struct net_device *ndev) /* if any of the above changed restart the FEC */ if (status_change) { + netif_stop_queue(ndev); napi_disable(&fep->napi); netif_tx_lock_bh(ndev); fec_restart(ndev); @@ -1804,6 +1805,7 @@ static void fec_enet_adjust_link(struct net_device *ndev) } } else { if (fep->link) { + netif_stop_queue(ndev); napi_disable(&fep->napi); netif_tx_lock_bh(ndev); fec_stop(ndev); -- 2.43.0