From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A9ED3CF42; Wed, 21 Feb 2024 14:19:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708525143; cv=none; b=c1DbGEMJ6Fkr7c0+uEMx9WZuUafF8n9LV4WX/hm7009fw0RdzS6uuH8/A7o74uQW/c/13WpDkHItFSKAdwrFNq5b7Vy0dyg8fZtisSaSqfsLtOWr8+CvurMdsfeuJnUFMrpFVmmDsZ0n5PyGMHQadvUINGMBXcw+qYOAn9JsAkc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708525143; c=relaxed/simple; bh=riBfJ836mLM57mShagqu0vv5qZHbEYBhn/cvj6iyLag=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=oFbKFDX+bavjHs8ZAK7ekef1UCoNX6/wQIwx0L0ileC8yTWLx1UGjamTIgTuCJ2j4/raHog74KtPe7JThaW7qM7HP/xE25LHZ5ub3qeaZRvUZyrgBhVz7aTcEYk3ktVu0hA3MoWgeVaI+2L5yxXCYZ34oTuSGb8vTsbQKUuR6wY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=pKtf/ss3; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="pKtf/ss3" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8DC76C433F1; Wed, 21 Feb 2024 14:19:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1708525143; bh=riBfJ836mLM57mShagqu0vv5qZHbEYBhn/cvj6iyLag=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pKtf/ss3pBtVrgBFqx1wukXAcdmkvnRFX0d0fSk8GnFnZi+emn124sfVcJZPgWhoO BmLuFv070jBah4F0FxG/u9PcxzGxekPOUYmhNnLJBdTndqHIQOs0l2Jv/cVsTEhMOn RMdtCxnyj2dtcO/0Mjk06Ajn9yhLPSUFfpkdZq44= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Filipe Manana , Qu Wenruo , David Sterba Subject: [PATCH 5.4 045/267] btrfs: defrag: reject unknown flags of btrfs_ioctl_defrag_range_args Date: Wed, 21 Feb 2024 14:06:26 +0100 Message-ID: <20240221125941.429940484@linuxfoundation.org> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20240221125940.058369148@linuxfoundation.org> References: <20240221125940.058369148@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Qu Wenruo commit 173431b274a9a54fc10b273b46e67f46bcf62d2e upstream. Add extra sanity check for btrfs_ioctl_defrag_range_args::flags. This is not really to enhance fuzzing tests, but as a preparation for future expansion on btrfs_ioctl_defrag_range_args. In the future we're going to add new members, allowing more fine tuning for btrfs defrag. Without the -ENONOTSUPP error, there would be no way to detect if the kernel supports those new defrag features. CC: stable@vger.kernel.org # 4.14+ Reviewed-by: Filipe Manana Signed-off-by: Qu Wenruo Reviewed-by: David Sterba Signed-off-by: David Sterba Signed-off-by: Greg Kroah-Hartman --- fs/btrfs/ioctl.c | 4 ++++ include/uapi/linux/btrfs.h | 3 +++ 2 files changed, 7 insertions(+) --- a/fs/btrfs/ioctl.c +++ b/fs/btrfs/ioctl.c @@ -3102,6 +3102,10 @@ static int btrfs_ioctl_defrag(struct fil kfree(range); goto out; } + if (range->flags & ~BTRFS_DEFRAG_RANGE_FLAGS_SUPP) { + ret = -EOPNOTSUPP; + goto out; + } /* compression requires us to start the IO */ if ((range->flags & BTRFS_DEFRAG_RANGE_COMPRESS)) { range->flags |= BTRFS_DEFRAG_RANGE_START_IO; --- a/include/uapi/linux/btrfs.h +++ b/include/uapi/linux/btrfs.h @@ -539,6 +539,9 @@ struct btrfs_ioctl_clone_range_args { */ #define BTRFS_DEFRAG_RANGE_COMPRESS 1 #define BTRFS_DEFRAG_RANGE_START_IO 2 +#define BTRFS_DEFRAG_RANGE_FLAGS_SUPP (BTRFS_DEFRAG_RANGE_COMPRESS | \ + BTRFS_DEFRAG_RANGE_START_IO) + struct btrfs_ioctl_defrag_range_args { /* start of the defrag operation */ __u64 start;