From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A44569D29; Wed, 21 Feb 2024 14:21:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708525282; cv=none; b=co4WXxRSJtVyBmEO0BWEU+3t6vPMWoDjxAxMbpcDbcptRs4QWmXTmY4b694oVOnv6D3/4vVJ5oKhYNR5EHt37yKd015p0ulcWbbLmBpiQHDYIqrfQ+JARtwasT9tEYkDJy1JFFqOD6nIq8bK+Dz25HIA4j0w43r1OkCsCx3kbxM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708525282; c=relaxed/simple; bh=eGJVFEtvM73fqZiN5KAs2kV6sswxncFEO/nC0hQJA7I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Ub4LmZEcIF7MYjvjvye+2208DV+9ei263uW7f2zq6L1M+dyrvk9ZJxBEDRwXwgRLs9JvEEKTA9GjMDrqDVx+v1dPDHYzh6loSd3u7TWcw8fWbVASMRpw3tTxM/U9Z+Mn/jn2EwWKFlRnyq1DTD1gW3ML5jLgqlSY0U1JWBV4pvE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=hVzT9uUp; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="hVzT9uUp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 84A4BC433C7; Wed, 21 Feb 2024 14:21:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1708525281; bh=eGJVFEtvM73fqZiN5KAs2kV6sswxncFEO/nC0hQJA7I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hVzT9uUpN4N6/bBXdz0ZTN5Svtu1ORxPqXLNPAAT+xNfhIY7QGWZdYVmWZDQaMOoF NPxfYVsxWqEPE7bgvKtiAUvA8/NyUAgyBH3yEXOrrwDYBGsYuEPyJ0A0STy8xOgPI/ 65a7EDSBwBQ6c8e7ekdz/MgkNn/6PT8bMNiYYihg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Yuluo Qiu , Celeste Liu , "Rafael J. Wysocki" , Sasha Levin Subject: [PATCH 5.4 070/267] ACPI: video: Add quirk for the Colorful X15 AT 23 Laptop Date: Wed, 21 Feb 2024 14:06:51 +0100 Message-ID: <20240221125942.182881674@linuxfoundation.org> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20240221125940.058369148@linuxfoundation.org> References: <20240221125940.058369148@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Yuluo Qiu [ Upstream commit 143176a46bdd3bfbe9ba2462bf94458e80d65ebf ] The Colorful X15 AT 23 ACPI video-bus device report spurious ACPI_VIDEO_NOTIFY_CYCLE events resulting in spurious KEY_SWITCHVIDEOMODE events being reported to userspace (and causing trouble there) when an external screen plugged in. Add a quirk setting the report_key_events mask to REPORT_BRIGHTNESS_KEY_EVENTS so that the ACPI_VIDEO_NOTIFY_CYCLE events will be ignored, while still reporting brightness up/down hotkey-presses to userspace normally. Signed-off-by: Yuluo Qiu Co-developed-by: Celeste Liu Signed-off-by: Celeste Liu Signed-off-by: Rafael J. Wysocki Signed-off-by: Sasha Levin --- drivers/acpi/acpi_video.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/acpi/acpi_video.c b/drivers/acpi/acpi_video.c index 9648ec76de2b..fd33fdbaffa9 100644 --- a/drivers/acpi/acpi_video.c +++ b/drivers/acpi/acpi_video.c @@ -568,6 +568,15 @@ static const struct dmi_system_id video_dmi_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "Vostro 3350"), }, }, + { + .callback = video_set_report_key_events, + .driver_data = (void *)((uintptr_t)REPORT_BRIGHTNESS_KEY_EVENTS), + .ident = "COLORFUL X15 AT 23", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "COLORFUL"), + DMI_MATCH(DMI_PRODUCT_NAME, "X15 AT 23"), + }, + }, /* * Some machines change the brightness themselves when a brightness * hotkey gets pressed, despite us telling them not to. In this case -- 2.43.0