From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 134D57A708; Wed, 21 Feb 2024 14:24:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708525480; cv=none; b=R5BSVpQ83SAHWi0BSp01PydjVsXGjTAXzMxBsCGU1Eh04LNs5MTxJWYulta+YWCHQOyqKxACtwlDlvd2iAyY6Ag/kRzteF0K90vFXptxo7iVgNgsC4RvnNRFLXsP6xakKyqOiKigHwx4WY4dWUKyO7DOnZ4TQ3RcFg0D3VLmLO0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708525480; c=relaxed/simple; bh=Pm8U5EVzPyzPEjvPzE2xiL3E/Z9hxVEkvyUdQqKovvI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=tMoD6J5fIlO1SFQT5KTMMxeqoCmAEqOyXdqvvGB1JpCC6m0KuRLEHkaaJiJA9A4F/2mOXV1Lq4dmmBRRKY+Vgn5hMgIc3S9C1yBXm/EUBptAw8D6MhtXP5fkdvClvoib3ZnTBlkxlkJBWGMgZzx/8qdWnEDQWd8R5sSZ0xbKVMY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=XFioN3o+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="XFioN3o+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 326B2C43390; Wed, 21 Feb 2024 14:24:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1708525479; bh=Pm8U5EVzPyzPEjvPzE2xiL3E/Z9hxVEkvyUdQqKovvI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XFioN3o+8QJZ/ZcWz0QWijl87zXG29NWomuP3FmZA99PIORCAKcCyOJQe8NBoxjaw 73ZqarowdfrlKHjBZgXAEPK1JRFPVrrqLnZvwTFYZipoGPOBgjuLTvnGN6BWLEnSLm /hZWIfOwsn7gD6CnbODmAkJFg026a6Z2/wGKOq98= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Felix Kuehling , =?UTF-8?q?Christian=20K=C3=B6nig?= , Alex Deucher , Srinivasan Shanmugam , Felix Kuehling , Sasha Levin Subject: [PATCH 5.4 139/267] drm/amdgpu: Drop fence check in to_amdgpu_amdkfd_fence() Date: Wed, 21 Feb 2024 14:08:00 +0100 Message-ID: <20240221125944.415470441@linuxfoundation.org> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20240221125940.058369148@linuxfoundation.org> References: <20240221125940.058369148@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Srinivasan Shanmugam [ Upstream commit bf2ad4fb8adca89374b54b225d494e0b1956dbea ] Return value of container_of(...) can't be null, so null check is not required for 'fence'. Hence drop its NULL check. Fixes the below: drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_fence.c:93 to_amdgpu_amdkfd_fence() warn: can 'fence' even be NULL? Cc: Felix Kuehling Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam Reviewed-by: Felix Kuehling Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_fence.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_fence.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_fence.c index 3107b9575929..eef7517c9d24 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_fence.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_fence.c @@ -88,7 +88,7 @@ struct amdgpu_amdkfd_fence *to_amdgpu_amdkfd_fence(struct dma_fence *f) return NULL; fence = container_of(f, struct amdgpu_amdkfd_fence, base); - if (fence && f->ops == &amdkfd_fence_ops) + if (f->ops == &amdkfd_fence_ops) return fence; return NULL; -- 2.43.0