From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C4963CF42; Wed, 21 Feb 2024 14:23:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708525392; cv=none; b=S8KREqs9D7VD9zpKkQ78pXUTGYJlF+Zqd1hkDunUlGaBmacI9bXOQmIQZIsuKWEkhgpe4Oete0qV54QNyn1cp1+qjths9/ILf+UeFjkxuDzkxgIJC5/CHdV51EgbQeAUrrBJQP58++GrXOOcth1G0+MRrVLTor081oCelVq0mA0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708525392; c=relaxed/simple; bh=7Qnkngq2wRA/tqMkCK2PQRtx+cTTSx2jksH6zWOvk90=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Xgf5xtNI2yVhJSRMQ2G9TdiD7jGoGqDjz3J60izfN2sb3cf7UK6J+UnekKjQmZUcQvgDEttsxaLboIco3+HDhGHfbKsrHKi58faMmiGzRrZzEAfOro8EgiDCvfNmHRC8Efuu1AwJhQ7lmgowcYXf+mmyJFS/igu+FINJIiRDOgI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=UX8Tg1i6; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="UX8Tg1i6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7E566C433C7; Wed, 21 Feb 2024 14:23:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1708525392; bh=7Qnkngq2wRA/tqMkCK2PQRtx+cTTSx2jksH6zWOvk90=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UX8Tg1i6IQuzo6+WhTGW/6jTug4YiPnSVUO8K4LXCkGNZuNu6aW2wHYFnHU28FHbx Ax0dHguqL6BsKivr6vk8KE48aGPA8dlaePgRcIRY1zz7s45gbTUuTwLWEHxhZd1HRR 9XKlksoI6mGav3YVRcklgieZ0Mpby+FsZ/NLEwH4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Benjamin Berg , Richard Weinberger , Sasha Levin Subject: [PATCH 5.4 142/267] um: Dont use vfprintf() for os_info() Date: Wed, 21 Feb 2024 14:08:03 +0100 Message-ID: <20240221125944.513946329@linuxfoundation.org> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20240221125940.058369148@linuxfoundation.org> References: <20240221125940.058369148@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Benjamin Berg [ Upstream commit 236f9fe39b02c15fa5530b53e9cca48354394389 ] The threads allocated inside the kernel have only a single page of stack. Unfortunately, the vfprintf function in standard glibc may use too much stack-space, overflowing it. To make os_info safe to be used by helper threads, use the kernel vscnprintf function into a smallish buffer and write out the information to stderr. Signed-off-by: Benjamin Berg Signed-off-by: Richard Weinberger Signed-off-by: Sasha Levin --- arch/um/os-Linux/util.c | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/arch/um/os-Linux/util.c b/arch/um/os-Linux/util.c index ecf2f390fad2..b76ac4df5da5 100644 --- a/arch/um/os-Linux/util.c +++ b/arch/um/os-Linux/util.c @@ -166,23 +166,38 @@ __uml_setup("quiet", quiet_cmd_param, "quiet\n" " Turns off information messages during boot.\n\n"); +/* + * The os_info/os_warn functions will be called by helper threads. These + * have a very limited stack size and using the libc formatting functions + * may overflow the stack. + * So pull in the kernel vscnprintf and use that instead with a fixed + * on-stack buffer. + */ +int vscnprintf(char *buf, size_t size, const char *fmt, va_list args); + void os_info(const char *fmt, ...) { + char buf[256]; va_list list; + int len; if (quiet_info) return; va_start(list, fmt); - vfprintf(stderr, fmt, list); + len = vscnprintf(buf, sizeof(buf), fmt, list); + fwrite(buf, len, 1, stderr); va_end(list); } void os_warn(const char *fmt, ...) { + char buf[256]; va_list list; + int len; va_start(list, fmt); - vfprintf(stderr, fmt, list); + len = vscnprintf(buf, sizeof(buf), fmt, list); + fwrite(buf, len, 1, stderr); va_end(list); } -- 2.43.0