From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6594C3D0A1; Wed, 21 Feb 2024 14:25:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708525534; cv=none; b=UlHVTuqjHEJykwtFGL31KVip10/Vt2yG0BafBaqyzIygTu80ia/E6HFQbPNpWkMSkLpXxFGItnLKODrEkp+p8UWl6Y14XFoCmv047m8nVg00iwSWdE5UdTViXYCEkbtHQBagtNYUshM7B6my/EVNus2XHx2zWgxtVpDyHyw4IP4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708525534; c=relaxed/simple; bh=o9iZk0f2BhzQgDoynd3HBGsK5+e541luEquJ9PEwSZE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HQOYqNCs5UikuO5TMlVa+PnZ6gCvIxUr71EnWqn6RrMDEcoVeLY/4CLPCwI2s5MBTuft3HAmA/6zwfjXKzfFwu2EYu0pz0j0yXtKJkSofrOlbIMl+sSPb9P+0LQCr9k0BnsutrZW2uIl+3vIdDUqoS4VBltTrCszn08ob1Uf/5c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=fmwlIR12; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="fmwlIR12" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D1677C433C7; Wed, 21 Feb 2024 14:25:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1708525534; bh=o9iZk0f2BhzQgDoynd3HBGsK5+e541luEquJ9PEwSZE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fmwlIR12kVIJXVcNAkYivt/EW5wPln5FzYkYzk1w6Gt+FWaoTOIKdTDxoGRXLcWip z0IRFr4iH8lxMx5K2D3/RoylJ0WwIjgEgJ7IbvGSx/BgM8ZolwcUksLr5KJ4FZMqjn 4u8+SfqVUgHTSGzQsEouarT2t60PpPKTeuqMqpk4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Zhang Rui , Guenter Roeck , Sasha Levin Subject: [PATCH 5.4 185/267] hwmon: (coretemp) Fix out-of-bounds memory access Date: Wed, 21 Feb 2024 14:08:46 +0100 Message-ID: <20240221125945.935989317@linuxfoundation.org> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20240221125940.058369148@linuxfoundation.org> References: <20240221125940.058369148@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Zhang Rui [ Upstream commit 4e440abc894585a34c2904a32cd54af1742311b3 ] Fix a bug that pdata->cpu_map[] is set before out-of-bounds check. The problem might be triggered on systems with more than 128 cores per package. Fixes: 7108b80a542b ("hwmon/coretemp: Handle large core ID value") Signed-off-by: Zhang Rui Cc: Link: https://lore.kernel.org/r/20240202092144.71180-2-rui.zhang@intel.com Signed-off-by: Guenter Roeck Stable-dep-of: fdaf0c8629d4 ("hwmon: (coretemp) Fix bogus core_id to attr name mapping") Signed-off-by: Sasha Levin --- drivers/hwmon/coretemp.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c index 0eabad344961..10e1d189a619 100644 --- a/drivers/hwmon/coretemp.c +++ b/drivers/hwmon/coretemp.c @@ -467,18 +467,14 @@ static int create_core_data(struct platform_device *pdev, unsigned int cpu, if (pkg_flag) { attr_no = PKG_SYSFS_ATTR_NO; } else { - index = ida_alloc(&pdata->ida, GFP_KERNEL); + index = ida_alloc_max(&pdata->ida, NUM_REAL_CORES - 1, GFP_KERNEL); if (index < 0) return index; + pdata->cpu_map[index] = topology_core_id(cpu); attr_no = index + BASE_SYSFS_ATTR_NO; } - if (attr_no > MAX_CORE_DATA - 1) { - err = -ERANGE; - goto ida_free; - } - tdata = init_temp_data(cpu, pkg_flag); if (!tdata) { err = -ENOMEM; -- 2.43.0