From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3FEB369962; Wed, 21 Feb 2024 14:26:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708525610; cv=none; b=j4ssDjEs0BJUMqPEUzOIn6rT3G05WPKYFvcWdaxt02zAO6h17p545b9VoMhRapxAOA+XnDEPiB8lIDnEiI2M2pdP4JwJ6dTrxGH8DeMIkFObkRCGXf0hexglFhvxnGOVBNlkxb+8XLRZnZ6VKMV/2Kod7eDOvHXHxQgwtdGHwi8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708525610; c=relaxed/simple; bh=rceEOwf1quwCN2iP/l6BghS+Dr44Ek0Cfpny3s+6kRg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HIUPcy2MloghjdEDOUSMoVgYg5EjCZvp3aUapSovckaJGM/MLU++/KT0s64CFSw+YpjF9KkbfsVDUdyP80iLCTbnaCcm4pHyQ371xQy5Ms2BWa9C0ny4745MSVYb7JiGVpUA3r3A2IEvzIzL1OFlqcNVx7Y6nx4arbAoQgF4YRs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=N/MoAYLR; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="N/MoAYLR" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4F891C433C7; Wed, 21 Feb 2024 14:26:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1708525609; bh=rceEOwf1quwCN2iP/l6BghS+Dr44Ek0Cfpny3s+6kRg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=N/MoAYLRWKsqcc9WeH57AROfPAMlCVsJSCoJjqTVNvHHYG+IV8XPhrvySDAffxuMx pZ/c/Q68SFqLeVLaRnGcuzTvweP417sbheLhGENAHUo6eiX/TSxR83bFC1FSBVVKpC wW7b2tTIiV14iGDbseJSyoPl9k44KzE1jyS/Ot0c= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, kernel test robot , "Christian A. Ehrhardt" , Rob Herring , Sasha Levin Subject: [PATCH 5.4 208/267] of: unittest: Fix compile in the non-dynamic case Date: Wed, 21 Feb 2024 14:09:09 +0100 Message-ID: <20240221125946.714638947@linuxfoundation.org> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20240221125940.058369148@linuxfoundation.org> References: <20240221125940.058369148@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Christian A. Ehrhardt [ Upstream commit 607aad1e4356c210dbef9022955a3089377909b2 ] If CONFIG_OF_KOBJ is not set, a device_node does not contain a kobj and attempts to access the embedded kobj via kref_read break the compile. Replace affected kref_read calls with a macro that reads the refcount if it exists and returns 1 if there is no embedded kobj. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202401291740.VP219WIz-lkp@intel.com/ Fixes: 4dde83569832 ("of: Fix double free in of_parse_phandle_with_args_map") Signed-off-by: Christian A. Ehrhardt Link: https://lore.kernel.org/r/20240129192556.403271-1-lk@c--e.de Signed-off-by: Rob Herring Signed-off-by: Sasha Levin --- drivers/of/unittest.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c index 7585df5e3daf..799519872f85 100644 --- a/drivers/of/unittest.c +++ b/drivers/of/unittest.c @@ -46,6 +46,12 @@ static struct unittest_results { failed; \ }) +#ifdef CONFIG_OF_KOBJ +#define OF_KREF_READ(NODE) kref_read(&(NODE)->kobj.kref) +#else +#define OF_KREF_READ(NODE) 1 +#endif + /* * Expected message may have a message level other than KERN_INFO. * Print the expected message only if the current loglevel will allow @@ -588,7 +594,7 @@ static void __init of_unittest_parse_phandle_with_args_map(void) pr_err("missing testcase data\n"); return; } - prefs[i] = kref_read(&p[i]->kobj.kref); + prefs[i] = OF_KREF_READ(p[i]); } rc = of_count_phandle_with_args(np, "phandle-list", "#phandle-cells"); @@ -690,9 +696,9 @@ static void __init of_unittest_parse_phandle_with_args_map(void) unittest(rc == -EINVAL, "expected:%i got:%i\n", -EINVAL, rc); for (i = 0; i < ARRAY_SIZE(p); ++i) { - unittest(prefs[i] == kref_read(&p[i]->kobj.kref), + unittest(prefs[i] == OF_KREF_READ(p[i]), "provider%d: expected:%d got:%d\n", - i, prefs[i], kref_read(&p[i]->kobj.kref)); + i, prefs[i], OF_KREF_READ(p[i])); of_node_put(p[i]); } } -- 2.43.0