From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 623C678B73; Wed, 21 Feb 2024 13:59:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708523967; cv=none; b=citZSrZjTvL/JV9EU13/CpaPtRfSpQqb69RP0uD23HozaU7LDfNEmxP5uRDq/LKPXw6aatVMoV+rbpplBqsV/Gvf8lB7scmHNTcOWSFZpJI6dmwSPwh1xYA1DlfPRRDqxHBpwWpUWKY6b1WFwRzqnCSJB+P0XrNu2cXoMLf9LQI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708523967; c=relaxed/simple; bh=N2EUR8k845CU1bhFV6yKC6LlnFMQRLukqSLmEsKqpZc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UUPtUo3/uPZ/PfqP54eXe5qjfdY8IkKoN5rFPtsplRLlZz1mAUQ8SkyZS7kowpjn89lEdRwPO/3HVRKhqQjS0D+WJhRKTZAy8WjBa87U69SXnLAeIrXUHmLt0StT/OVpC57HIIWDhAV01YE3DHwceyH10ESYXz+8sX3K0dhP4OM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=PWRHtevN; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="PWRHtevN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C6385C43394; Wed, 21 Feb 2024 13:59:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1708523967; bh=N2EUR8k845CU1bhFV6yKC6LlnFMQRLukqSLmEsKqpZc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PWRHtevNdqvhCgKNDRpefMnBfqUzVbwK4VspG7gHeKqFpu4FKCvmVR/bTR2pUCcp+ YzbqNvG+IiIeVnkO1azgZmAeUniQiVKq/XA3vwxw1vMYaz5WvinQVsLd/UQ32rmZXA VIIZjde/MRE9gZ5yPyR8jbM21e7Uh4VXB0YWV8AA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Stephen Rothwell , Michael Ellerman , Sasha Levin Subject: [PATCH 5.10 106/379] powerpc: pmd_move_must_withdraw() is only needed for CONFIG_TRANSPARENT_HUGEPAGE Date: Wed, 21 Feb 2024 14:04:45 +0100 Message-ID: <20240221125958.053883407@linuxfoundation.org> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20240221125954.917878865@linuxfoundation.org> References: <20240221125954.917878865@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Stephen Rothwell [ Upstream commit 0d555b57ee660d8a871781c0eebf006e855e918d ] The linux-next build of powerpc64 allnoconfig fails with: arch/powerpc/mm/book3s64/pgtable.c:557:5: error: no previous prototype for 'pmd_move_must_withdraw' 557 | int pmd_move_must_withdraw(struct spinlock *new_pmd_ptl, | ^~~~~~~~~~~~~~~~~~~~~~ Caused by commit: c6345dfa6e3e ("Makefile.extrawarn: turn on missing-prototypes globally") Fix it by moving the function definition under CONFIG_TRANSPARENT_HUGEPAGE like the prototype. The function is only called when CONFIG_TRANSPARENT_HUGEPAGE=y. Signed-off-by: Stephen Rothwell [mpe: Flesh out change log from linux-next patch] Signed-off-by: Michael Ellerman Link: https://msgid.link/20231127132809.45c2b398@canb.auug.org.au Signed-off-by: Sasha Levin --- arch/powerpc/mm/book3s64/pgtable.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/powerpc/mm/book3s64/pgtable.c b/arch/powerpc/mm/book3s64/pgtable.c index e18ae50a275c..a86d932a7c30 100644 --- a/arch/powerpc/mm/book3s64/pgtable.c +++ b/arch/powerpc/mm/book3s64/pgtable.c @@ -446,6 +446,7 @@ void ptep_modify_prot_commit(struct vm_area_struct *vma, unsigned long addr, set_pte_at(vma->vm_mm, addr, ptep, pte); } +#ifdef CONFIG_TRANSPARENT_HUGEPAGE /* * For hash translation mode, we use the deposited table to store hash slot * information and they are stored at PTRS_PER_PMD offset from related pmd @@ -467,6 +468,7 @@ int pmd_move_must_withdraw(struct spinlock *new_pmd_ptl, return true; } +#endif /* * Does the CPU support tlbie? -- 2.43.0