From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9711178B53; Wed, 21 Feb 2024 14:03:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708524206; cv=none; b=YPBDL1iJtw5GNvizCFCrZB04AV3IeVZJwMiOUoVh9ygSShFrY/6zxjvMuumHlJFhRCnCSiUnidUQr/Aj5AU6keI4eBWJrDk9dQzCkNXxwhMhXR+7PA5oe4xDTrjhojnkmbXwtyZ0MMef2Y5VbThUbXaL5/iOXGnwR+qXO+zx5K0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708524206; c=relaxed/simple; bh=Ad5TYzfp4B8+WnWKxtbd/bheyViIj7Te0pBA1SDrrb8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Io5dMRlC+qNFQodl0gulIi1/sw5B6Qo9rifMUi+SdYKIEUhSPOCqLEx6zoqHQCg8K9FkElW1bw6UijBvC+SfdbWd/KB2R8VEvwjqVU7//lhNZgARnjBamHecYxoUKd7oQ3RwSZ1XcJxlaJ30wZoydw1XtpjB0bTRgIVoZVJ1EvU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=qzYQa5f/; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="qzYQa5f/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 05312C433C7; Wed, 21 Feb 2024 14:03:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1708524206; bh=Ad5TYzfp4B8+WnWKxtbd/bheyViIj7Te0pBA1SDrrb8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qzYQa5f/aB5UmCHoRfj3RILVeqYiABcKR0PeXEMAnqfzGUq0Xnc3iBFz6VYnWrklf 5axiJ2OGmmenL+kOPIp30MuHzYRXoOzu19R1ExNDKi8t2Dy/hvSYpB7TOcJZn+VGa9 xon62SBZh2nNEUAAkqRMjrhfugrJoImkh4X5O+ZI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Takashi Iwai , Sasha Levin Subject: [PATCH 5.10 176/379] ALSA: hda: Refer to correct stream index at loops Date: Wed, 21 Feb 2024 14:05:55 +0100 Message-ID: <20240221130000.119835156@linuxfoundation.org> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20240221125954.917878865@linuxfoundation.org> References: <20240221125954.917878865@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Takashi Iwai [ Upstream commit 26257869672fd4a06a60c2da841e15fb2cb47bbe ] In a couple of loops over the all streams, we check the bitmap against the loop counter. A more correct reference would be, however, the index of each stream, instead. This patch corrects the check of bitmaps to the stream index. Note that this change doesn't fix anything for now; all existing drivers set up the stream indices properly, hence the loop count is always equal with the stream index. That said, this change is only for consistency. Link: https://lore.kernel.org/r/20231121154125.4888-1-tiwai@suse.de Signed-off-by: Takashi Iwai Signed-off-by: Sasha Levin --- sound/hda/hdac_stream.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/sound/hda/hdac_stream.c b/sound/hda/hdac_stream.c index 5570722458ca..e510bf09967d 100644 --- a/sound/hda/hdac_stream.c +++ b/sound/hda/hdac_stream.c @@ -605,17 +605,15 @@ void snd_hdac_stream_timecounter_init(struct hdac_stream *azx_dev, struct hdac_stream *s; bool inited = false; u64 cycle_last = 0; - int i = 0; list_for_each_entry(s, &bus->stream_list, list) { - if (streams & (1 << i)) { + if ((streams & (1 << s->index))) { azx_timecounter_init(s, inited, cycle_last); if (!inited) { inited = true; cycle_last = s->tc.cycle_last; } } - i++; } snd_pcm_gettime(runtime, &runtime->trigger_tstamp); @@ -660,14 +658,13 @@ void snd_hdac_stream_sync(struct hdac_stream *azx_dev, bool start, unsigned int streams) { struct hdac_bus *bus = azx_dev->bus; - int i, nwait, timeout; + int nwait, timeout; struct hdac_stream *s; for (timeout = 5000; timeout; timeout--) { nwait = 0; - i = 0; list_for_each_entry(s, &bus->stream_list, list) { - if (!(streams & (1 << i++))) + if (!(streams & (1 << s->index))) continue; if (start) { -- 2.43.0