From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8DA397CF33; Wed, 21 Feb 2024 14:08:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708524484; cv=none; b=QXYxLKctCRN6wqZ0F3o8nyTkGX2GPJXIOaLzRSoor/kmwIKjImlLvKnMbl9tnFu7rq7DcFMYuRpBqNf/lVMb1sKqMN+l/lBWEAJfscf0BE5AOCYn/bdgrcu+/wWnlmpJqH6z+xTSCbanC1Iw2LuPZCpYb+ZlmuCjzgcX9L9BA84= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708524484; c=relaxed/simple; bh=imJmeiK4IN5Qih0oq8eYNc+KicEACC8YYtKGpifX8d0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TnrfYNsldEkLsB6rbHiMH8Kl5Dw0OQ7PrxJCcF1nmKVf9n5/pCFn/a4yXoHbCnI8fzkUCYAXoepu70rs9TvvDdBgJ2l4+F30F5eat+mdaq5DBeZdvcYi6d6uREJuQBafbgH3jkm3SixeDpHtYSVwTqfGEu3F9OhjjYhzgMxbhL4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=zH4PGR+9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="zH4PGR+9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E5FBCC433C7; Wed, 21 Feb 2024 14:08:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1708524484; bh=imJmeiK4IN5Qih0oq8eYNc+KicEACC8YYtKGpifX8d0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=zH4PGR+9PKLXeE0uxFGTpUYL/fdLcED68bSaQwZmQmjCu0p1bACAo/pnrSHg2MKW8 QjrAPozrTLvUkSPwYuC8ugAIE/+CXVn1y/BdRBcHQKelEERYYFoFGDN8wkjqXcAhqz upxlsgRt1MC0NUkpTAjeDYjrDGcij5+1H+wKPmEY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Zhang Rui , Guenter Roeck , Sasha Levin Subject: [PATCH 5.10 259/379] hwmon: (coretemp) Fix out-of-bounds memory access Date: Wed, 21 Feb 2024 14:07:18 +0100 Message-ID: <20240221130002.579059961@linuxfoundation.org> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20240221125954.917878865@linuxfoundation.org> References: <20240221125954.917878865@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Zhang Rui [ Upstream commit 4e440abc894585a34c2904a32cd54af1742311b3 ] Fix a bug that pdata->cpu_map[] is set before out-of-bounds check. The problem might be triggered on systems with more than 128 cores per package. Fixes: 7108b80a542b ("hwmon/coretemp: Handle large core ID value") Signed-off-by: Zhang Rui Cc: Link: https://lore.kernel.org/r/20240202092144.71180-2-rui.zhang@intel.com Signed-off-by: Guenter Roeck Stable-dep-of: fdaf0c8629d4 ("hwmon: (coretemp) Fix bogus core_id to attr name mapping") Signed-off-by: Sasha Levin --- drivers/hwmon/coretemp.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c index 5b2057ce5a59..7f6615ef8c88 100644 --- a/drivers/hwmon/coretemp.c +++ b/drivers/hwmon/coretemp.c @@ -467,18 +467,14 @@ static int create_core_data(struct platform_device *pdev, unsigned int cpu, if (pkg_flag) { attr_no = PKG_SYSFS_ATTR_NO; } else { - index = ida_alloc(&pdata->ida, GFP_KERNEL); + index = ida_alloc_max(&pdata->ida, NUM_REAL_CORES - 1, GFP_KERNEL); if (index < 0) return index; + pdata->cpu_map[index] = topology_core_id(cpu); attr_no = index + BASE_SYSFS_ATTR_NO; } - if (attr_no > MAX_CORE_DATA - 1) { - err = -ERANGE; - goto ida_free; - } - tdata = init_temp_data(cpu, pkg_flag); if (!tdata) { err = -ENOMEM; -- 2.43.0