From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C020C7BB14; Wed, 21 Feb 2024 13:31:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708522280; cv=none; b=VE+X9pC/BU2tQrswsk2sUyXJ3evFRa+S2aSeBh84o/e24xAtK0+2Jd982MoJUWP2WFoKQvLeaSZm72pob3NqdLxpq7bKQwP6hML7raXcI9zcdZbEgfDB2qjzQcIycFR5NIaz5HlZkpz2eqEml/vvTVKVJ2Cpy/ic+ombtejzFLo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708522280; c=relaxed/simple; bh=nmJFC7W5Lxk189T+Gtd7Vs+Hc6tIyDbmjkEW3/q0/YI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tBcPdfCMSkb8AfkFw39doCki5tB1/ZyMyaUouny6ANn+ni5b12uoDP2yARGdtgqZAZbgnHg7R/36fLN+5vNItAHHY+B/LdWHN29OqkU7zKwXCPH4vNUYuXSrFcDeqlviGsZWQX7LwJHk3glsoj2JEAZEYYNJP4XsGNGzWYQA8KI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=AZGxK1P9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="AZGxK1P9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B924EC433F1; Wed, 21 Feb 2024 13:31:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1708522280; bh=nmJFC7W5Lxk189T+Gtd7Vs+Hc6tIyDbmjkEW3/q0/YI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AZGxK1P9UqE0MskBZvdUF6qpgmF2TNzx/ND5xoFSt9zN7DGTvTJ8AtCVpCqhg1AbP WQUDHxk7CzVvnzTwD1d7EKcn3Zkmimy0rIKGc9HX/ig1zSg1rCz84/T2hvju1WJILp 82M+OYFbUqdnjP8opRo0zPibkLmq6fzbmI3RRl5c= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Christophe Leroy , Michael Ellerman , Kunwu Chan , Sasha Levin Subject: [PATCH 5.15 125/476] powerpc/mm: Fix null-pointer dereference in pgtable_cache_add Date: Wed, 21 Feb 2024 14:02:56 +0100 Message-ID: <20240221130012.605195918@linuxfoundation.org> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20240221130007.738356493@linuxfoundation.org> References: <20240221130007.738356493@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Kunwu Chan [ Upstream commit f46c8a75263f97bda13c739ba1c90aced0d3b071 ] kasprintf() returns a pointer to dynamically allocated memory which can be NULL upon failure. Ensure the allocation was successful by checking the pointer validity. Suggested-by: Christophe Leroy Suggested-by: Michael Ellerman Signed-off-by: Kunwu Chan Signed-off-by: Michael Ellerman Link: https://msgid.link/20231204023223.2447523-1-chentao@kylinos.cn Signed-off-by: Sasha Levin --- arch/powerpc/mm/init-common.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/mm/init-common.c b/arch/powerpc/mm/init-common.c index 3a82f89827a5..4bc8f0c893a2 100644 --- a/arch/powerpc/mm/init-common.c +++ b/arch/powerpc/mm/init-common.c @@ -105,7 +105,7 @@ void pgtable_cache_add(unsigned int shift) * as to leave enough 0 bits in the address to contain it. */ unsigned long minalign = max(MAX_PGTABLE_INDEX_SIZE + 1, HUGEPD_SHIFT_MASK + 1); - struct kmem_cache *new; + struct kmem_cache *new = NULL; /* It would be nice if this was a BUILD_BUG_ON(), but at the * moment, gcc doesn't seem to recognize is_power_of_2 as a @@ -118,7 +118,8 @@ void pgtable_cache_add(unsigned int shift) align = max_t(unsigned long, align, minalign); name = kasprintf(GFP_KERNEL, "pgtable-2^%d", shift); - new = kmem_cache_create(name, table_size, align, 0, ctor(shift)); + if (name) + new = kmem_cache_create(name, table_size, align, 0, ctor(shift)); if (!new) panic("Could not allocate pgtable cache for order %d", shift); -- 2.43.0