From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5270915FA85; Mon, 27 May 2024 18:59:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716836368; cv=none; b=CS1IUKtcJjLSzRO0VRb53r+iebUOjuJVsX5jbEvr8iK/9BunRCdNLWyGAdQk9Y2UURGkqjuR2bFP7nkmb1jy5Nbs3znYBue+9yDBLdmg7p59OOhWSEzZYyv9C3zN7SLFue+53xwLHgSI/hI+s3+nrW+fzjJ1AOG+Y+j+WPnhggA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716836368; c=relaxed/simple; bh=RvHP4iKUEnbvfIJ0yMDcVZZkLUwZw7lVQfu3OXOXiFA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Aff0BCqjYcfIAOPgnUfdtD+eqJNfMrE5L8w5MlLmwj1+woAriWYzz6p3s1tQErggcP0fjxwgSE8nbPs/4Ap+05R04XZM9vMzjHFvNGmbI9sdRAQAH7P1ZVEuGoBmfbXlEf3/zPCAAut9TJtwSLts/a0cC7T5ZRomeOhfQQDOWZY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=BJVg00VK; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="BJVg00VK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 83252C2BBFC; Mon, 27 May 2024 18:59:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1716836367; bh=RvHP4iKUEnbvfIJ0yMDcVZZkLUwZw7lVQfu3OXOXiFA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BJVg00VK867nmGPWWMi+M6EQHyPzoaaJo+LN5AvPnuZbdAiRiznP8QzRnVOXFsnkf CM70W/bKJ5Yi8KZ8AZp1knZw/8HXkcRBNDNCiW0b1IxshgBvvXKm2A0qUnLQUfjlcJ Of0uJBA/NEoDgWAWs1pf3qV0NPSqr/bDgvVX2oqA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Chao Yu , Jaegeuk Kim , stable@kernel.org Subject: [PATCH 6.9 026/427] f2fs: fix false alarm on invalid block address Date: Mon, 27 May 2024 20:51:13 +0200 Message-ID: <20240527185604.112052394@linuxfoundation.org> X-Mailer: git-send-email 2.45.1 In-Reply-To: <20240527185601.713589927@linuxfoundation.org> References: <20240527185601.713589927@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.9-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jaegeuk Kim commit b864ddb57eb00c4ea1e6801c7b2f70f1db2a7f4b upstream. f2fs_ra_meta_pages can try to read ahead on invalid block address which is not the corruption case. Cc: # v6.9+ Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=218770 Fixes: 31f85ccc84b8 ("f2fs: unify the error handling of f2fs_is_valid_blkaddr") Reviewed-by: Chao Yu Signed-off-by: Jaegeuk Kim Signed-off-by: Greg Kroah-Hartman --- fs/f2fs/checkpoint.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c index 5d05a413f451..55d444bec5c0 100644 --- a/fs/f2fs/checkpoint.c +++ b/fs/f2fs/checkpoint.c @@ -179,22 +179,22 @@ static bool __f2fs_is_valid_blkaddr(struct f2fs_sb_info *sbi, break; case META_SIT: if (unlikely(blkaddr >= SIT_BLK_CNT(sbi))) - goto err; + goto check_only; break; case META_SSA: if (unlikely(blkaddr >= MAIN_BLKADDR(sbi) || blkaddr < SM_I(sbi)->ssa_blkaddr)) - goto err; + goto check_only; break; case META_CP: if (unlikely(blkaddr >= SIT_I(sbi)->sit_base_addr || blkaddr < __start_cp_addr(sbi))) - goto err; + goto check_only; break; case META_POR: if (unlikely(blkaddr >= MAX_BLKADDR(sbi) || blkaddr < MAIN_BLKADDR(sbi))) - goto err; + goto check_only; break; case DATA_GENERIC: case DATA_GENERIC_ENHANCE: @@ -228,6 +228,7 @@ static bool __f2fs_is_valid_blkaddr(struct f2fs_sb_info *sbi, return true; err: f2fs_handle_error(sbi, ERROR_INVALID_BLKADDR); +check_only: return false; } -- 2.45.1