From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E17C717D363 for ; Fri, 31 May 2024 19:57:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717185457; cv=none; b=ODYTKNHnrl2BpWrsM0UaueScE8l/+DknGuAEO+y7n2RovY92NTb9qcWDWkjBe+NMsTxf0ghqbF/oOAM8pNYlxKo4vfOqUK/MKOpRY1iKuwoYTGQYVlaIdrhwPiNaQm32t1yE6Wso7ToyJS43MuNTqREZDVjTAzjrS1yKCSqKPME= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717185457; c=relaxed/simple; bh=RsqO07LtaR/1pQ294RLwenEBg2L8jtETbGsARD5fAjo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VtOfEir2fCNU5rEcJOan/ZKnTAyvbWu/ifs/WLr4dnbCjxEGWrnDGFGNKcjop5SNmJr3t6IzVaO5SPfmgykb71tlydG+JgVyZgGYzOZtBKAfRhoC+5MCbZtBW9qT9pJ/T8Cm/VJA+1IkGzhxWtslWRBHSzK3YOltBAe15qdoFwU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=C4HouJ4O; arc=none smtp.client-ip=192.198.163.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="C4HouJ4O" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1717185456; x=1748721456; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=RsqO07LtaR/1pQ294RLwenEBg2L8jtETbGsARD5fAjo=; b=C4HouJ4OTGRfzQMIiQ+EEmsBxQebetk+ZPiuZ0jI9C+UAdRvIVmNgvo5 9KnV2LDa3AYkfloZSbwSMk9vgdi+jmd/72MCR/GU7Zab5kpwi08EG7OqC 3Evm3BgnRRcqUa6JOrnWI4GzwEo7JwwpYM+8Cjja1vvaCWfWXZUHQTFCI IePhQo3+Z3xGGNbFY1Z2rBXMl21AwmI70A+dA9BPdMkr70/N/8cOhO7fN LYH2uj4bxygcqVKXDN7K/OmP9K8p6UI+dGk8VqTfgForpr6usHno70Lqa lm3Y8TNwboNZS8z39O+XOaLZ2lXOeUk+OUaR592qMFnWFrfUxWmpuuSBX w==; X-CSE-ConnectionGUID: YEXHAdIjSGK72lQSAd3UrA== X-CSE-MsgGUID: M/Ed5rG8QNiWE9vkn0v44g== X-IronPort-AV: E=McAfee;i="6600,9927,11089"; a="13501148" X-IronPort-AV: E=Sophos;i="6.08,205,1712646000"; d="scan'208";a="13501148" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 May 2024 12:57:33 -0700 X-CSE-ConnectionGUID: KoVO3zmHRBm5PSLOFDbLfA== X-CSE-MsgGUID: /Lt1zt62TxGKKJVhQXyUeg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,205,1712646000"; d="scan'208";a="59438873" Received: from agluck-desk3.sc.intel.com ([172.25.222.70]) by fmviesa002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 May 2024 12:57:32 -0700 From: Tony Luck To: Greg Kroah-Hartman , Andrew Morton , Thomas Gleixner , Borislav Petkov Cc: Fenghua Yu , Reinette Chatre , Maciej Wieczor-Retman , Peter Newman , James Morse , Babu Moger , Drew Fustini , Dave Martin , linux-kernel@vger.kernel.org, patches@lists.linux.dev, Tony Luck Subject: [PATCH 2/3] x86/resctrl: Replace open code cacheinfo search in pseudo_lock_region_init() Date: Fri, 31 May 2024 12:57:19 -0700 Message-ID: <20240531195720.232561-3-tony.luck@intel.com> X-Mailer: git-send-email 2.45.0 In-Reply-To: <20240531195720.232561-1-tony.luck@intel.com> References: <20240531195720.232561-1-tony.luck@intel.com> Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Use get_cpu_cacheinfo_level() instead of open coded search. Signed-off-by: Tony Luck --- arch/x86/kernel/cpu/resctrl/pseudo_lock.c | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/arch/x86/kernel/cpu/resctrl/pseudo_lock.c b/arch/x86/kernel/cpu/resctrl/pseudo_lock.c index aacf236dfe3b..1bbfd3c1e300 100644 --- a/arch/x86/kernel/cpu/resctrl/pseudo_lock.c +++ b/arch/x86/kernel/cpu/resctrl/pseudo_lock.c @@ -292,9 +292,8 @@ static void pseudo_lock_region_clear(struct pseudo_lock_region *plr) */ static int pseudo_lock_region_init(struct pseudo_lock_region *plr) { - struct cpu_cacheinfo *ci; + struct cacheinfo *ci; int ret; - int i; /* Pick the first cpu we find that is associated with the cache. */ plr->cpu = cpumask_first(&plr->d->cpu_mask); @@ -306,15 +305,11 @@ static int pseudo_lock_region_init(struct pseudo_lock_region *plr) goto out_region; } - ci = get_cpu_cacheinfo(plr->cpu); - - plr->size = rdtgroup_cbm_to_size(plr->s->res, plr->d, plr->cbm); - - for (i = 0; i < ci->num_leaves; i++) { - if (ci->info_list[i].level == plr->s->res->cache_level) { - plr->line_size = ci->info_list[i].coherency_line_size; - return 0; - } + ci = get_cpu_cacheinfo_level(plr->cpu, plr->s->res->cache_level); + if (ci) { + plr->line_size = ci->coherency_line_size; + plr->size = rdtgroup_cbm_to_size(plr->s->res, plr->d, plr->cbm); + return 0; } ret = -1; -- 2.45.0