From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 216A3196C93; Thu, 6 Jun 2024 14:18:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717683517; cv=none; b=ar54/i65ykhQukzyFnFsn53LSbeB3CyS2CgG6rDWuI1hbDvsBeMxVkfl/ZbNnX95mlHMgEGRQyHvJkcR6XV28OI3evpF1HLFmx52xY7CT4XFbz1QyuPcXml+WYfK/BkZNWPz2C90vu5u1dHr6z/bPzbB6R1mnt7qLjoLUxHNdH0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717683517; c=relaxed/simple; bh=7Rc5ogxBKnnxc11yoBLFRsjZ6Ib87yPCSPrX6o8sG4k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=A2PTzpFyMZCBgTg/V40x/nXGZSwztv7pWyYmPIoNXIWJNkuc+Eb248anFSt++Y8eo9Ava4XAmJNc1turHLIHsSPNm2ppoyn+2NFve/rE/CJZ4PHeYv0ASOY3a2LJspbDP5N1mzJF4fnFC7sVe/MdJRtQ0oWT8HcfxQBnkLWqoiU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=KgUQQxz9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="KgUQQxz9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 80A9FC32782; Thu, 6 Jun 2024 14:18:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1717683516; bh=7Rc5ogxBKnnxc11yoBLFRsjZ6Ib87yPCSPrX6o8sG4k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KgUQQxz9ZNXPyt/pbglGdXgVnRNTkhHSLk1fMdfzDV5NoTZEMz59eUkOKtx6oK1oM UQZgZJhqjfpE0LCDNr66cM0zjjRXlBlyR/UOSpY0SY31dMWcWGxN6mJdcjRxeCmEK3 SHfoiN3Kg7wBFkKK+AhjGKQA2B5ZPdwh2BOM5g2I= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Arnaldo Carvalho de Melo , Adrian Hunter , Arnaldo Carvalho de Melo , Ian Rogers , Jiri Olsa , Namhyung Kim , Sasha Levin Subject: [PATCH 6.6 428/744] perf record: Fix debug message placement for test consumption Date: Thu, 6 Jun 2024 16:01:40 +0200 Message-ID: <20240606131746.195866499@linuxfoundation.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240606131732.440653204@linuxfoundation.org> References: <20240606131732.440653204@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Adrian Hunter [ Upstream commit 792bc998baf9ae17297b1f93b1edc3ca34a0b7e2 ] evlist__config() might mess up the debug output consumed by test "Test per-thread recording" in "Miscellaneous Intel PT testing". Move it out from between the debug prints: "perf record opening and mmapping events" and "perf record done opening and mmapping events" Fixes: da4062021e0e6da5 ("perf tools: Add debug messages and comments for testing") Closes: https://lore.kernel.org/linux-perf-users/ZhVfc5jYLarnGzKa@x1/ Reported-by: Arnaldo Carvalho de Melo Signed-off-by: Adrian Hunter Tested-by: Arnaldo Carvalho de Melo Cc: Ian Rogers Cc: Jiri Olsa Cc: Namhyung Kim Link: https://lore.kernel.org/r/20240411075447.17306-1-adrian.hunter@intel.com Signed-off-by: Arnaldo Carvalho de Melo Signed-off-by: Sasha Levin --- tools/perf/builtin-record.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c index 96a3e122655b7..b94ae33a343c2 100644 --- a/tools/perf/builtin-record.c +++ b/tools/perf/builtin-record.c @@ -1317,8 +1317,6 @@ static int record__open(struct record *rec) struct record_opts *opts = &rec->opts; int rc = 0; - evlist__config(evlist, opts, &callchain_param); - evlist__for_each_entry(evlist, pos) { try_again: if (evsel__open(pos, pos->core.cpus, pos->core.threads) < 0) { @@ -2428,6 +2426,8 @@ static int __cmd_record(struct record *rec, int argc, const char **argv) evlist__uniquify_name(rec->evlist); + evlist__config(rec->evlist, opts, &callchain_param); + /* Debug message used by test scripts */ pr_debug3("perf record opening and mmapping events\n"); if (record__open(rec) != 0) { -- 2.43.0