From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C298D1C53AC; Thu, 6 Jun 2024 14:21:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717683678; cv=none; b=SuLTjyKKuhZvpC/ElWUx71jp888wSk5PW2SnQ8SWVgdJRDlhjxtPm7+0X9gYifbJxzRaWumDoHl2+WPPN83wTDuBKsggEOA15u5ZnVnJZAGCRwod3CU1SD+oB2e/ZuV8ERQcz8UQaker1lx2mOXFet+B+jiFSb3q+6EeevmO4nQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717683678; c=relaxed/simple; bh=LfnDgQd27EB2H8Zh1pxsgbfafKLc9cwQOd2EOQeQV7w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tOqIk4BFmeS8UM1b0peREpESZ1+MrQvuv3+vm+IkI/5y9mIV01Ys8z+Enem/dUi1Qq62rveOBUxZlH0ihQj3EkZVbuxRewzYjo6PVJVkyc72lc/tYVPOWpPE1JROidg+B8ZrJCdTkPlYZLJnmcUGS3Q9mFxStSoOXir4lKnFpUk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ooMPBAof; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ooMPBAof" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9FB3BC32782; Thu, 6 Jun 2024 14:21:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1717683678; bh=LfnDgQd27EB2H8Zh1pxsgbfafKLc9cwQOd2EOQeQV7w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ooMPBAofP6+rOKnIDZMZwPc/i/Beb+KsOPTtnKlIQK/ndsNGTo4oy5T7zLH1/MOHP 18OQbOkyGZnA9TRKP4leZHnz3/Rcbjxg/frw5haDJkQ72LKIvW3jOIeBUZcFpJEal+ asNFLle4+cj0OkrODYLWzUbvXU+u8Q9owSNRVhOA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Johannes Berg , Tiwei Bie , Richard Weinberger , Sasha Levin Subject: [PATCH 6.6 578/744] um: vector: fix bpfflash parameter evaluation Date: Thu, 6 Jun 2024 16:04:10 +0200 Message-ID: <20240606131750.997827280@linuxfoundation.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240606131732.440653204@linuxfoundation.org> References: <20240606131732.440653204@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Johannes Berg [ Upstream commit 584ed2f76ff5fe360d87a04d17b6520c7999e06b ] With W=1 the build complains about a pointer compared to zero, clearly the result should've been compared. Fixes: 9807019a62dc ("um: Loadable BPF "Firmware" for vector drivers") Signed-off-by: Johannes Berg Reviewed-by: Tiwei Bie Signed-off-by: Richard Weinberger Signed-off-by: Sasha Levin --- arch/um/drivers/vector_kern.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/um/drivers/vector_kern.c b/arch/um/drivers/vector_kern.c index 131b7cb295767..94a4dfac6c236 100644 --- a/arch/um/drivers/vector_kern.c +++ b/arch/um/drivers/vector_kern.c @@ -141,7 +141,7 @@ static bool get_bpf_flash(struct arglist *def) if (allow != NULL) { if (kstrtoul(allow, 10, &result) == 0) - return (allow > 0); + return result > 0; } return false; } -- 2.43.0