From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7ED671A254F; Thu, 6 Jun 2024 14:22:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717683767; cv=none; b=Gg2JGCl2QkcJFfb33EiWirnbt0FGDdvmtkFYxH0VQtIOjBzUNYwSbETjXNLVdZVEH/iyUnxMtwBeIP4WbrX694dDIa+AVK9NDW+m3QeMbkcMOa5ss0AF+QNMKfocuDf+dKLgNbapLoh+hNoTDcrs6Kn3br08oJzfFycON8C9bJU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717683767; c=relaxed/simple; bh=UtfRzWXnTe7h6eqwL3Tpk3H03ScXsx71cdOv11VOjGk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=AtLTE3xabhgBEOnoEjtZHih82SrDSDCMeA2Q4VdiH0c87XeVJWSXSCUG5kiuAZnsueO7XXSguSV1P7a6aGG4Ljbhq3u5pbUCjupwiNNBPZMpQU9eJ2xo06lGmrzVK30hSsS8Pk94qDhIQCcaRzb0rYBTZOLcOJ66UJChfv2zVYw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=DLfDeHFp; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="DLfDeHFp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 52D2AC2BD10; Thu, 6 Jun 2024 14:22:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1717683767; bh=UtfRzWXnTe7h6eqwL3Tpk3H03ScXsx71cdOv11VOjGk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DLfDeHFpJbSSIMTZLKKGAanG5LGhP89GURqoTE8GV7vk8UygHdKbmxLs8gyTfIQTZ zs6jWuG1fR2/6KUBg5tc5ZeXrM1poxVXLj1tDIWvj2QHMG0lcf8i2jzplE4QSRD5Qe tY0KEuD3AcHNCKo9aylk2zW1dSeU6S+YbUS1stsA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Srinivas Pandruvada , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Hans de Goede Subject: [PATCH 6.6 743/744] platform/x86/intel/tpmi: Handle error from tpmi_process_info() Date: Thu, 6 Jun 2024 16:06:55 +0200 Message-ID: <20240606131756.308704113@linuxfoundation.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240606131732.440653204@linuxfoundation.org> References: <20240606131732.440653204@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Srinivas Pandruvada commit 2920141fc149f71bad22361946417bc43783ed7f upstream. When tpmi_process_info() returns error, fail to load the driver. This can happen if call to ioremap() returns error. Signed-off-by: Srinivas Pandruvada Reviewed-by: Ilpo Järvinen Cc: stable@vger.kernel.org # v6.3+ Link: https://lore.kernel.org/r/20240423204619.3946901-2-srinivas.pandruvada@linux.intel.com Reviewed-by: Hans de Goede Signed-off-by: Hans de Goede Signed-off-by: Greg Kroah-Hartman --- drivers/platform/x86/intel/tpmi.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) --- a/drivers/platform/x86/intel/tpmi.c +++ b/drivers/platform/x86/intel/tpmi.c @@ -733,8 +733,11 @@ static int intel_vsec_tpmi_init(struct a * when actual device nodes created outside this * loop via tpmi_create_devices(). */ - if (pfs->pfs_header.tpmi_id == TPMI_INFO_ID) - tpmi_process_info(tpmi_info, pfs); + if (pfs->pfs_header.tpmi_id == TPMI_INFO_ID) { + ret = tpmi_process_info(tpmi_info, pfs); + if (ret) + return ret; + } if (pfs->pfs_header.tpmi_id == TPMI_CONTROL_ID) tpmi_set_control_base(auxdev, tpmi_info, pfs);