From: Jason Gunthorpe <jgg@nvidia.com>
To: Daniel Mentz <danielmentz@google.com>
Cc: iommu@lists.linux.dev, Joerg Roedel <joro@8bytes.org>,
linux-arm-kernel@lists.infradead.org,
Robin Murphy <robin.murphy@arm.com>,
Will Deacon <will@kernel.org>,
Michael Shavit <mshavit@google.com>,
Nicolin Chen <nicolinc@nvidia.com>,
patches@lists.linux.dev, Ryan Roberts <ryan.roberts@arm.com>,
Mostafa Saleh <smostafa@google.com>
Subject: Re: [PATCH v2 03/10] iommu/arm-smmu-v3: Add arm_smmu_strtab_l1/2_idx()
Date: Wed, 12 Jun 2024 08:49:36 -0300 [thread overview]
Message-ID: <20240612114936.GW19897@nvidia.com> (raw)
In-Reply-To: <CAE2F3rBA-QHBROY9T0eo6HzYkMOs51+xMXHZLSjnz4=D6XEszQ@mail.gmail.com>
On Tue, Jun 11, 2024 at 05:37:26PM -0700, Daniel Mentz wrote:
> On Mon, Jun 10, 2024 at 5:31 PM Jason Gunthorpe <jgg@nvidia.com> wrote:
> > +static inline unsigned int arm_smmu_strtab_l1_idx(unsigned int sid)
>
> Existing code appears to be exclusively using the data type u32 to
> store StreamIDs.
Not entirely exclusively, but often enough, I fixed it.
Thanks,
Jason
next prev parent reply other threads:[~2024-06-12 11:49 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-11 0:31 [PATCH v2 00/10] Tidy some minor things in the stream table/cd table area Jason Gunthorpe
2024-06-11 0:31 ` [PATCH v2 01/10] iommu/arm-smmu-v3: Do not zero the strtab twice Jason Gunthorpe
2024-06-11 0:50 ` Nicolin Chen
2024-06-11 23:52 ` Daniel Mentz
2024-06-12 11:46 ` Jason Gunthorpe
2024-06-11 0:31 ` [PATCH v2 02/10] iommu/arm-smmu-v3: Shrink the strtab l1_desc array Jason Gunthorpe
2024-06-11 0:55 ` Nicolin Chen
2024-06-11 0:31 ` [PATCH v2 03/10] iommu/arm-smmu-v3: Add arm_smmu_strtab_l1/2_idx() Jason Gunthorpe
2024-06-11 2:00 ` Nicolin Chen
2024-06-12 0:30 ` Daniel Mentz
2024-06-12 12:09 ` Jason Gunthorpe
2024-06-12 0:37 ` Daniel Mentz
2024-06-12 11:49 ` Jason Gunthorpe [this message]
2024-06-11 0:31 ` [PATCH v2 04/10] iommu/arm-smmu-v3: Add types for each level of the 2 level stream table Jason Gunthorpe
2024-06-11 2:13 ` Nicolin Chen
2024-06-11 0:31 ` [PATCH v2 05/10] iommu/arm-smmu-v3: Reorganize struct arm_smmu_strtab_cfg Jason Gunthorpe
2024-06-11 2:31 ` Nicolin Chen
2024-07-02 18:46 ` Will Deacon
2024-07-09 19:42 ` Jason Gunthorpe
2024-06-11 0:31 ` [PATCH v2 06/10] iommu/arm-smmu-v3: Remove strtab_base/cfg Jason Gunthorpe
2024-06-11 2:36 ` Nicolin Chen
2024-06-11 0:31 ` [PATCH v2 07/10] iommu/arm-smmu-v3: Do not use devm for the cd table allocations Jason Gunthorpe
2024-06-11 2:39 ` Nicolin Chen
2024-06-11 0:31 ` [PATCH v2 08/10] iommu/arm-smmu-v3: Shrink the cdtab l1_desc array Jason Gunthorpe
2024-06-11 3:02 ` Nicolin Chen
2024-07-02 18:46 ` Will Deacon
2024-07-09 19:52 ` Jason Gunthorpe
2024-07-09 23:53 ` Jason Gunthorpe
2024-06-11 0:31 ` [PATCH v2 09/10] iommu/arm-smmu-v3: Add types for each level of the CD table Jason Gunthorpe
2024-06-11 3:12 ` Nicolin Chen
2024-06-11 0:31 ` [PATCH v2 10/10] iommu/arm-smmu-v3: Reorganize struct arm_smmu_ctx_desc_cfg Jason Gunthorpe
2024-06-11 3:25 ` Nicolin Chen
2024-06-11 3:27 ` [PATCH v2 00/10] Tidy some minor things in the stream table/cd table area Nicolin Chen
2024-07-02 18:43 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240612114936.GW19897@nvidia.com \
--to=jgg@nvidia.com \
--cc=danielmentz@google.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mshavit@google.com \
--cc=nicolinc@nvidia.com \
--cc=patches@lists.linux.dev \
--cc=robin.murphy@arm.com \
--cc=ryan.roberts@arm.com \
--cc=smostafa@google.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).