From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A273143878; Thu, 13 Jun 2024 11:41:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718278873; cv=none; b=lHnTnQIQYyHzPFEMwtngQ5ciMlJPt5akGqVu56eekNIY2VeBFU1X3du3LdE2JZ1kLmFj5jDZEePRtRQZ0RRm4WwgcAlJOdpwJOROpPE02eW9WXLfp6kbz+NxHM/TvLmPGTW36rqRSzkiJ3P5X9s1osR4Tpuk8vR4RkXX4iiGs2g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718278873; c=relaxed/simple; bh=heswE5XBfzDcENl0uUE67M65dqXOATbH+jSYAFFO7DQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KyNo7azdZX708/fTshk8L+YQrDiQTS8PqAgs9O1tQ6iRxhStCRL8a+53srKhChxqql/Foe/V/UbTWAwwgouhesOO+fh6Bmut4b/mH99MAXJfC32WKpREXB81lZlp7g4Q6xOtMJW9900Af6y5H+hnhO9yn4/XVoPEINeAnsVyO/0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=UtwN+AdM; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="UtwN+AdM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0B836C2BBFC; Thu, 13 Jun 2024 11:41:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1718278873; bh=heswE5XBfzDcENl0uUE67M65dqXOATbH+jSYAFFO7DQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UtwN+AdMBBcqjZyHN6Uxgl4L/VaK2lmHrWTJDzad6KmR40BMApvSm4ebCCk71jdcI o4uxlU7+rcENtPk4D7fQhhcrldwG+zZs7CA1Nc1o5ZBSRUk+kwu04c9eaNazYmPszG 7OAO98Ab1Z+G9B6Agv9xzNHdWgvh4xPzLX3XRtSM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Edward Liaw , Cyrill Gorcunov , Eric Biederman , Shuah Khan , Andrew Morton , Sasha Levin Subject: [PATCH 4.19 081/213] selftests/kcmp: remove unused open mode Date: Thu, 13 Jun 2024 13:32:09 +0200 Message-ID: <20240613113231.136019449@linuxfoundation.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240613113227.969123070@linuxfoundation.org> References: <20240613113227.969123070@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Edward Liaw [ Upstream commit eb59a58113717df04b8a8229befd8ab1e5dbf86e ] Android bionic warns that open modes are ignored if O_CREAT or O_TMPFILE aren't specified. The permissions for the file are set above: fd1 = open(kpath, O_RDWR | O_CREAT | O_TRUNC, 0644); Link: https://lkml.kernel.org/r/20240429234610.191144-1-edliaw@google.com Fixes: d97b46a64674 ("syscalls, x86: add __NR_kcmp syscall") Signed-off-by: Edward Liaw Reviewed-by: Cyrill Gorcunov Cc: Eric Biederman Cc: Shuah Khan Signed-off-by: Andrew Morton Signed-off-by: Sasha Levin --- tools/testing/selftests/kcmp/kcmp_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/kcmp/kcmp_test.c b/tools/testing/selftests/kcmp/kcmp_test.c index 25110c7c0b3ed..d7a8e321bb16b 100644 --- a/tools/testing/selftests/kcmp/kcmp_test.c +++ b/tools/testing/selftests/kcmp/kcmp_test.c @@ -91,7 +91,7 @@ int main(int argc, char **argv) ksft_print_header(); ksft_set_plan(3); - fd2 = open(kpath, O_RDWR, 0644); + fd2 = open(kpath, O_RDWR); if (fd2 < 0) { perror("Can't open file"); ksft_exit_fail(); -- 2.43.0