From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5AC3F1E492; Wed, 19 Jun 2024 13:32:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718803968; cv=none; b=jvRlGE2fFM7cMexyf1gacjIQbpqhZqcJrr67gXu8+v/kCTgcgFyYQikj0TqKGW05/5mBytpJMGI7VzUj9yybJs8MVuNFO5n9JxqCJjPKM8MJ3G5REgeozyyr5Ax4GI9IioA9QZV8OtbO7jBFzFGbH6elDi8Po0f1V5mCDEImVSs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718803968; c=relaxed/simple; bh=QP0Zai9XSjIMx6FoZT2eT6XfLcRljsqYcQLHRBINb+A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BrGLLjA2vAoURbbEVy6Nl/2SCUveq8H3X7Ot0dJBkTS+bW46yUsrnoqp48R7BuMbfwBFwgBx93xOlclX5mtqS694M4zN1ze7YHGYppbpraYHqdG/33HF4RXLXLSwSSet9jUscOrQoJ1KxHfKDQU9aNGdaneSm189yZFi+4DfHLE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=WpK8mxEk; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="WpK8mxEk" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D804EC2BBFC; Wed, 19 Jun 2024 13:32:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1718803968; bh=QP0Zai9XSjIMx6FoZT2eT6XfLcRljsqYcQLHRBINb+A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WpK8mxEk+SCMajlXes//fruwCDFm/w1VbkFRsVzRA2Zf2xXWXnerwyvIo6TXBxNpV limTlAdrLgn4NEbFLoGezzqn9louPWYUkcvJiGz/ft3f5trs8l5klmTY01FQCZJaUG 3bMtH7AUREA+vPWOrvPxI3f94b7ey46yeB2rTZ5s= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jean-Baptiste Maneyrol , Jonathan Cameron Subject: [PATCH 6.1 163/217] iio: imu: inv_icm42600: delete unneeded update watermark call Date: Wed, 19 Jun 2024 14:56:46 +0200 Message-ID: <20240619125602.980924497@linuxfoundation.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240619125556.491243678@linuxfoundation.org> References: <20240619125556.491243678@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jean-Baptiste Maneyrol commit 245f3b149e6cc3ac6ee612cdb7042263bfc9e73c upstream. Update watermark will be done inside the hwfifo_set_watermark callback just after the update_scan_mode. It is useless to do it here. Fixes: 7f85e42a6c54 ("iio: imu: inv_icm42600: add buffer support in iio devices") Cc: stable@vger.kernel.org Signed-off-by: Jean-Baptiste Maneyrol Link: https://lore.kernel.org/r/20240527210008.612932-1-inv.git-commit@tdk.com Signed-off-by: Jonathan Cameron Signed-off-by: Greg Kroah-Hartman --- drivers/iio/imu/inv_icm42600/inv_icm42600_accel.c | 4 ---- drivers/iio/imu/inv_icm42600/inv_icm42600_gyro.c | 4 ---- 2 files changed, 8 deletions(-) --- a/drivers/iio/imu/inv_icm42600/inv_icm42600_accel.c +++ b/drivers/iio/imu/inv_icm42600/inv_icm42600_accel.c @@ -128,10 +128,6 @@ static int inv_icm42600_accel_update_sca /* update data FIFO write */ inv_icm42600_timestamp_apply_odr(ts, 0, 0, 0); ret = inv_icm42600_buffer_set_fifo_en(st, fifo_en | st->fifo.en); - if (ret) - goto out_unlock; - - ret = inv_icm42600_buffer_update_watermark(st); out_unlock: mutex_unlock(&st->lock); --- a/drivers/iio/imu/inv_icm42600/inv_icm42600_gyro.c +++ b/drivers/iio/imu/inv_icm42600/inv_icm42600_gyro.c @@ -128,10 +128,6 @@ static int inv_icm42600_gyro_update_scan /* update data FIFO write */ inv_icm42600_timestamp_apply_odr(ts, 0, 0, 0); ret = inv_icm42600_buffer_set_fifo_en(st, fifo_en | st->fifo.en); - if (ret) - goto out_unlock; - - ret = inv_icm42600_buffer_update_watermark(st); out_unlock: mutex_unlock(&st->lock);