From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA92316F907 for ; Fri, 21 Jun 2024 22:39:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719009559; cv=none; b=GH8CQKGTf6SMhj3yUXvKfbRUj8+2kY6JX6O+eMVXn72hHB9cHIDfyK1IjpaAhY77jndNwXPP4ANFPIA9XIiXLlZIarEdT7hYqSVd593HTciAF4yl5rwVFlEIcvwRU+tLKe/aID4BzZK++CoRGmg3Sc76xt7sQqUY5HuQzRPHQic= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719009559; c=relaxed/simple; bh=xalcDH7xFOjOU7DCVtWTUs2cEEKmxyG55J7Dr5SEIFI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gp0pDxBa1LMs/aMz/e55n9i++hxxvNB3iYLT80hb2ybwl7FlL81h1MXDSzLbSOXaaEUxX0eZOW8UmIZwJysCyJow6tqLUiMZHdAi8ae70wKfmiJ3zDtVcpfwrmA0v1N+oFp6r6uHRIZe5PUe+zPBku+SFnnWmwkm7fPE9YsI8Ns= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=hs7SZu0Q; arc=none smtp.client-ip=192.198.163.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="hs7SZu0Q" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719009557; x=1750545557; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=xalcDH7xFOjOU7DCVtWTUs2cEEKmxyG55J7Dr5SEIFI=; b=hs7SZu0Q63M9Eq33AgQqiqrw2Psqb+Ko85re/WWMaVpmJdpAKD8nWmm5 MDuov1eMrf7+59wiEvY/pB/kxW7//Rn4r6b9Jz/khIXFHPC42m2MkxMXx x7Wr9OdVv6rCR23InAplwSNVH1je9gLF7nLabkA9cxXmLi7szPh3wwEvb mWIJVcfJcxrIClLMbxWzztWk2pVVV3GKD/7IDLB+Z44oYefI2TzygU597 1G8SNHNv6HaT8pKkSfMJ/T3W4A6ock4hJC4lUGb0+Mj+1j5YamxnKjzht y/pCo2vXPJayVhMqJz/8qtZDRmyKGlIf/cGNj9EsnIh50ToRZe9uTRb3M Q==; X-CSE-ConnectionGUID: pUZKobt9TheoDh+NzaJDbw== X-CSE-MsgGUID: JQ8SQqzdQsyvH0KvwaI06g== X-IronPort-AV: E=McAfee;i="6700,10204,11110"; a="26691313" X-IronPort-AV: E=Sophos;i="6.08,256,1712646000"; d="scan'208";a="26691313" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2024 15:39:08 -0700 X-CSE-ConnectionGUID: Vd5SlHl2S0avmLchpcO93w== X-CSE-MsgGUID: bOPiIp2mRjSwvifUxk6ybg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,256,1712646000"; d="scan'208";a="73935665" Received: from agluck-desk3.sc.intel.com ([172.25.222.70]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2024 15:39:08 -0700 From: Tony Luck To: Fenghua Yu , Reinette Chatre , Maciej Wieczor-Retman , Peter Newman , James Morse , Babu Moger , Drew Fustini , Dave Martin Cc: x86@kernel.org, linux-kernel@vger.kernel.org, patches@lists.linux.dev, Tony Luck Subject: [PATCH v21 09/18] x86/resctrl: Add a new field to struct rmid_read for summation of domains Date: Fri, 21 Jun 2024 15:38:50 -0700 Message-ID: <20240621223859.43471-10-tony.luck@intel.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240621223859.43471-1-tony.luck@intel.com> References: <20240621223859.43471-1-tony.luck@intel.com> Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When a user reads a monitor file rdtgroup_mondata_show() calls mon_event_read() to package up all the required details into an rmid_read structure which is passed across the smp_call*() infrastructure to code that will read data from hardware and return the value (or error status) in the rmid_read structure. Sub-NUMA Cluster (SNC) mode adds files with new semantics. These require the smp_call-ed code to sum event data from all domains that share an L3 cache. Add a pointer to the L3 "cacheinfo" structure to struct rmid_read for the data collection routines to use to pick the domains to be summed. Reinette suggested that the rmid_read structure has become complex enough to warrant documentation of each of its fields and provided the kerneldoc documentation for struct rmid_read. Co-developed-by: Reinette Chatre Signed-off-by: Reinette Chatre Signed-off-by: Tony Luck --- arch/x86/kernel/cpu/resctrl/internal.h | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/arch/x86/kernel/cpu/resctrl/internal.h b/arch/x86/kernel/cpu/resctrl/internal.h index 135190e0711c..d04018b8b571 100644 --- a/arch/x86/kernel/cpu/resctrl/internal.h +++ b/arch/x86/kernel/cpu/resctrl/internal.h @@ -144,12 +144,31 @@ union mon_data_bits { } u; }; +/** + * struct rmid_read - Data passed across smp_call*() to read event count. + * @rgrp: Resource group for which the counter is being read. If it is a parent + * resource group then its event count is summed with the count from all + * its child resource groups. + * @r: Resource describing the properties of the event being read. + * @d: Domain that the counter should be read from. If NULL then sum all + * domains in @r sharing L3 @ci.id + * @evtid: Which monitor event to read. + * @first: Initialize MBM counter when true. + * @ci: Cacheinfo for L3. Only set when @d is NULL. Used when summing domains. + * @err: Error encountered when reading counter. + * @val: Returned value of event counter. If @rgrp is a parent resource group, + * @val contains the sum of event counts from its child resource groups. + * If @d is NULL, @val includes the sum of all domains in @r sharing @ci.id, + * (summed across child resource groups if @rgrp is a parent resource group). + * @arch_mon_ctx: Hardware monitor allocated for this read request (MPAM only). + */ struct rmid_read { struct rdtgroup *rgrp; struct rdt_resource *r; struct rdt_mon_domain *d; enum resctrl_event_id evtid; bool first; + struct cacheinfo *ci; int err; u64 val; void *arch_mon_ctx; -- 2.45.2