From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5964763D; Tue, 2 Jul 2024 17:32:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719941545; cv=none; b=JKtX6FUgL9IGMtZVhvrYNWzc3dDSUyUZsTixVL7D/SaiDRWm9hpGlCN0mMFz+e/R25LuYX6xjfh+78Tp6d6AH9QPplZFXJXxcWpIeVlgqWDmcuA92U8NSbsZ+gKJdznXQCECPyuwXvJuTLJhbSOvT3i95YpifCto6XslfbvLy70= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719941545; c=relaxed/simple; bh=5ClzP0Kf8xNIGh9iexwh+w4+tB0X1exiRy7NVl9sOTM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Xd81MoTj/iG5Rmt6oRni6upAEb9enkSmLQ9GS+V2FhYPyh05JD2mA5TmDOKbjG9VPgd8KRY0mbnpGel/CoOhdDzVtGsJ9ETTP+twtGrPEo/nUF0p2gPppYewTIoPAnrDJtfhqoHYuPoJDfTC0QGYCR/Pd/cZuNh6cw4aG41LxPk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=FxjNzVdv; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="FxjNzVdv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CC6B4C116B1; Tue, 2 Jul 2024 17:32:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1719941545; bh=5ClzP0Kf8xNIGh9iexwh+w4+tB0X1exiRy7NVl9sOTM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FxjNzVdvMi7dbAH5ZdXhXj8tCYkStL5iPD+vvCu4UEtJCm3oCVnbfS8d7IR+lCFu7 FO8/donJPvnXCyUVI7Igr4F+47qxZf88IulSkiCQl1xb92tWyt8uCNrvR1p7P9DbBs iSubj+8L0h3+oLNJ6y4OEMV9v2eKrHJJ5HeHDrqc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Bryan ODonoghue , Stephen Boyd , Johan Hovold , Linus Walleij Subject: [PATCH 6.1 065/128] pinctrl: qcom: spmi-gpio: drop broken pm8008 support Date: Tue, 2 Jul 2024 19:04:26 +0200 Message-ID: <20240702170228.691105889@linuxfoundation.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240702170226.231899085@linuxfoundation.org> References: <20240702170226.231899085@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Johan Hovold commit 8da86499d4cd125a9561f9cd1de7fba99b0aecbf upstream. The SPMI GPIO driver assumes that the parent device is an SPMI device and accesses random data when backcasting the parent struct device pointer for non-SPMI devices. Fortunately this does not seem to cause any issues currently when the parent device is an I2C client like the PM8008, but this could change if the structures are reorganised (e.g. using structure randomisation). Notably the interrupt implementation is also broken for non-SPMI devices. Also note that the two GPIO pins on PM8008 are used for interrupts and reset so their practical use should be limited. Drop the broken GPIO support for PM8008 for now. Fixes: ea119e5a482a ("pinctrl: qcom-pmic-gpio: Add support for pm8008") Cc: stable@vger.kernel.org # 5.13 Reviewed-by: Bryan O'Donoghue Reviewed-by: Stephen Boyd Signed-off-by: Johan Hovold Link: https://lore.kernel.org/r/20240529162958.18081-9-johan+linaro@kernel.org Signed-off-by: Linus Walleij Signed-off-by: Greg Kroah-Hartman --- drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 1 - 1 file changed, 1 deletion(-) --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c @@ -1204,7 +1204,6 @@ static const struct of_device_id pmic_gp { .compatible = "qcom,pm7250b-gpio", .data = (void *) 12 }, { .compatible = "qcom,pm7325-gpio", .data = (void *) 10 }, { .compatible = "qcom,pm8005-gpio", .data = (void *) 4 }, - { .compatible = "qcom,pm8008-gpio", .data = (void *) 2 }, { .compatible = "qcom,pm8019-gpio", .data = (void *) 6 }, /* pm8150 has 10 GPIOs with holes on 2, 5, 7 and 8 */ { .compatible = "qcom,pm8150-gpio", .data = (void *) 10 },