From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8C0513BC0B; Wed, 3 Jul 2024 11:01:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720004495; cv=none; b=jc6iovKLTk7LIRTPxm3yfRNtGeV4Gc2S+UspXjYBU2PCSKeI7GlJX+OOTRgPqlQwB0sqs62m8Kxuqe86WJMXKwHTTEGPnad1WlNlF1M86xkpZL4LWLoQzqV8oQz4IGeFylWVoOywPOrEUm7X11j3acoEtL1u9gVFTnXrld1H7ZI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720004495; c=relaxed/simple; bh=dhPZcHDHtnDDAraZn6lni8OHkVAIShDSLKsp87PC3UQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IXff5CpbJa/cdt6Jh/e2GKC40KIH70/fG5+cEemm17PxviwVy7KtqPPbtbZEYaDqTYxJvklpx5Y0f+cIhtUewFl5dbhwEePiTdIAzS/YlRUENn/moc+lGVc/Mp+X9GB6w05aOzLeuebZloNSuci+EYRyllcR8Fem2jjtm3QnHOI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=K3j1v6d6; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="K3j1v6d6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 72916C2BD10; Wed, 3 Jul 2024 11:01:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1720004494; bh=dhPZcHDHtnDDAraZn6lni8OHkVAIShDSLKsp87PC3UQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=K3j1v6d6v6mw8WXp+Dh/xonhqgg9fwgIR5cmJ/7AXb3tvuM0wyR8Cud6NfHgM/OsR 8MzKdrdQb8+iNm+2oSocYEsQpP7Iy9edaw0UyZm0H4pBJ5KwJYPsw6hKhNPY+4JOc6 nITou1V5iGyg1tdKn3ndLerzqo8NlOC40ZfPYacc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Chen Hanxiao , Benjamin Coddington , Chuck Lever , Trond Myklebust , Sasha Levin Subject: [PATCH 5.10 053/290] SUNRPC: return proper error from gss_wrap_req_priv Date: Wed, 3 Jul 2024 12:37:14 +0200 Message-ID: <20240703102906.205926005@linuxfoundation.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240703102904.170852981@linuxfoundation.org> References: <20240703102904.170852981@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Chen Hanxiao [ Upstream commit 33c94d7e3cb84f6d130678d6d59ba475a6c489cf ] don't return 0 if snd_buf->len really greater than snd_buf->buflen Signed-off-by: Chen Hanxiao Fixes: 0c77668ddb4e ("SUNRPC: Introduce trace points in rpc_auth_gss.ko") Reviewed-by: Benjamin Coddington Reviewed-by: Chuck Lever Signed-off-by: Trond Myklebust Signed-off-by: Sasha Levin --- net/sunrpc/auth_gss/auth_gss.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/sunrpc/auth_gss/auth_gss.c b/net/sunrpc/auth_gss/auth_gss.c index 2ff66a6a7e54c..7ce4a6b7cfae6 100644 --- a/net/sunrpc/auth_gss/auth_gss.c +++ b/net/sunrpc/auth_gss/auth_gss.c @@ -1855,8 +1855,10 @@ gss_wrap_req_priv(struct rpc_cred *cred, struct gss_cl_ctx *ctx, offset = (u8 *)p - (u8 *)snd_buf->head[0].iov_base; maj_stat = gss_wrap(ctx->gc_gss_ctx, offset, snd_buf, inpages); /* slack space should prevent this ever happening: */ - if (unlikely(snd_buf->len > snd_buf->buflen)) + if (unlikely(snd_buf->len > snd_buf->buflen)) { + status = -EIO; goto wrap_failed; + } /* We're assuming that when GSS_S_CONTEXT_EXPIRED, the encryption was * done anyway, so it's safe to put the request on the wire: */ if (maj_stat == GSS_S_CONTEXT_EXPIRED) -- 2.43.0