From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34C971DFC7; Wed, 3 Jul 2024 11:03:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720004623; cv=none; b=Wko5+ZMGDBMx94VPcoHpKDZ6NmDR2LNsuP4pbRGwG3O0nGpNszi9IOxhXwDaWA2ish5NxjQ5jn1zrN047aP6feEyzW3PK+d5SpAdZOyUpIt/UrdCUoynYXjO9utGChGnqz1bCR5kt8Xr1adoOZM4ZCNOOLx8mL43WfKBAMuulBg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720004623; c=relaxed/simple; bh=DmrdjEoU7lVDDK17DvsjHEPjH5oonKwxdbbKPxxJyIU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZkW4qQl4LthcSAqFIkm4M7Rofpr0iQmP5y9QEAoFTwwbT+Io7KbrJNChhMCurkpG8RgsXnuiXdbjb0DcSyEvL5otspOXdtLRIVkpRiMyax7XS9VKCDvczQ9P/kSs1u77dZBJAD1UKskxXD+3IN13evPZAKkqtaqZJRNOi1jNAUw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=wF5m1Qu7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="wF5m1Qu7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8291DC2BD10; Wed, 3 Jul 2024 11:03:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1720004623; bh=DmrdjEoU7lVDDK17DvsjHEPjH5oonKwxdbbKPxxJyIU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wF5m1Qu729coCkjD32DHSC8O5pSxDc8UacuxVVesBOgNbQ6RuYkXckVWjekdtXoxV HkZo0DQc8ifCUDtSxgbx9MujieebCmAQ4Wc+4lO0Yk5XB6MSA/kWchoK68bHsMWrqv fiOjTWDnPJCmcislDClmYHSmXLTzz5aEUhL0YfTk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Oleg Nesterov , Rachel Menge , Boqun Feng , Wei Fu , Jens Axboe , Allen Pais , Christian Brauner , Frederic Weisbecker , "Joel Fernandes (Google)" , Joel Granados , Josh Triplett , Lai Jiangshan , Mateusz Guzik , Mathieu Desnoyers , Mike Christie , Neeraj Upadhyay , "Paul E. McKenney" , "Steven Rostedt (Google)" , Zqiang , Thomas Gleixner , Andrew Morton , Sasha Levin Subject: [PATCH 5.10 104/290] zap_pid_ns_processes: clear TIF_NOTIFY_SIGNAL along with TIF_SIGPENDING Date: Wed, 3 Jul 2024 12:38:05 +0200 Message-ID: <20240703102908.124468497@linuxfoundation.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240703102904.170852981@linuxfoundation.org> References: <20240703102904.170852981@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Oleg Nesterov [ Upstream commit 7fea700e04bd3f424c2d836e98425782f97b494e ] kernel_wait4() doesn't sleep and returns -EINTR if there is no eligible child and signal_pending() is true. That is why zap_pid_ns_processes() clears TIF_SIGPENDING but this is not enough, it should also clear TIF_NOTIFY_SIGNAL to make signal_pending() return false and avoid a busy-wait loop. Link: https://lkml.kernel.org/r/20240608120616.GB7947@redhat.com Fixes: 12db8b690010 ("entry: Add support for TIF_NOTIFY_SIGNAL") Signed-off-by: Oleg Nesterov Reported-by: Rachel Menge Closes: https://lore.kernel.org/all/1386cd49-36d0-4a5c-85e9-bc42056a5a38@linux.microsoft.com/ Reviewed-by: Boqun Feng Tested-by: Wei Fu Reviewed-by: Jens Axboe Cc: Allen Pais Cc: Christian Brauner Cc: Frederic Weisbecker Cc: Joel Fernandes (Google) Cc: Joel Granados Cc: Josh Triplett Cc: Lai Jiangshan Cc: Mateusz Guzik Cc: Mathieu Desnoyers Cc: Mike Christie Cc: Neeraj Upadhyay Cc: Paul E. McKenney Cc: Steven Rostedt (Google) Cc: Zqiang Cc: Thomas Gleixner Signed-off-by: Andrew Morton Signed-off-by: Sasha Levin --- kernel/pid_namespace.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/pid_namespace.c b/kernel/pid_namespace.c index 20243682e6056..e032b1ce79649 100644 --- a/kernel/pid_namespace.c +++ b/kernel/pid_namespace.c @@ -221,6 +221,7 @@ void zap_pid_ns_processes(struct pid_namespace *pid_ns) */ do { clear_thread_flag(TIF_SIGPENDING); + clear_thread_flag(TIF_NOTIFY_SIGNAL); rc = kernel_wait4(-1, NULL, __WALL, NULL); } while (rc != -ECHILD); -- 2.43.0