From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E247D173328; Wed, 3 Jul 2024 11:05:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720004703; cv=none; b=oymVuXEnrLyqnCQZPoIKmC56nOBWzY7UANNagc87OfOPISuJPfRFMBJ2mccPGYHFiomMiNyjdwrp93+8tQvUCQD0EBEO9RyWcdrODrA+/Ln3q8CWFbCng3r6xODLxt/WN+IRtZgsUIF2qp+qth81zNPyWqj6Mg2xL5qBBI99wT0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720004703; c=relaxed/simple; bh=At/e8hvLSc0nZzOJhYGRPzMPwY+dk/Xv95iRbZrn1A4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lAlfH0647mb3JSDoIOt7NSeuHQdVdumI7xBLUbUTrIajE2y+yoyP32NPEJ2BFEicZR4CMiQeMK348voyuRwWEG4ZowxCarGVTRiMdPpqY/eQwlNm3K7jFA1gmN35p8D1TvZ3N91SK0s+tkYFgH2igG2eSz1060iPMCjMAlymoDw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=E8Kk+4Qv; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="E8Kk+4Qv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 22132C2BD10; Wed, 3 Jul 2024 11:05:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1720004702; bh=At/e8hvLSc0nZzOJhYGRPzMPwY+dk/Xv95iRbZrn1A4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=E8Kk+4Qvts9ID7PH2FA0J+poKyOlyibrNXpU8Qs6EUrFFdsdlNv8jVpjW2QrIXBs7 ARGcsbC8CzNf1GiQAKGBWmS7IUQ2Al2au8s881WlFYIS5HSwbE+6kWUPcRfaKiNBPq BKpb/lLE3eexa/0cbM7paU4OD89dVaFP4CVwZJik= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jan Kara , Roman Smirnov , Sergey Shtylyov , Sasha Levin Subject: [PATCH 5.10 131/290] udf: udftime: prevent overflow in udf_disk_stamp_to_time() Date: Wed, 3 Jul 2024 12:38:32 +0200 Message-ID: <20240703102909.133709142@linuxfoundation.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240703102904.170852981@linuxfoundation.org> References: <20240703102904.170852981@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Roman Smirnov [ Upstream commit 3b84adf460381169c085e4bc09e7b57e9e16db0a ] An overflow can occur in a situation where src.centiseconds takes the value of 255. This situation is unlikely, but there is no validation check anywere in the code. Found by Linux Verification Center (linuxtesting.org) with Svace. Suggested-by: Jan Kara Signed-off-by: Roman Smirnov Reviewed-by: Sergey Shtylyov Signed-off-by: Jan Kara Message-Id: <20240327132755.13945-1-r.smirnov@omp.ru> Signed-off-by: Sasha Levin --- fs/udf/udftime.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/fs/udf/udftime.c b/fs/udf/udftime.c index fce4ad976c8c2..26169b1f482c3 100644 --- a/fs/udf/udftime.c +++ b/fs/udf/udftime.c @@ -60,13 +60,18 @@ udf_disk_stamp_to_time(struct timespec64 *dest, struct timestamp src) dest->tv_sec = mktime64(year, src.month, src.day, src.hour, src.minute, src.second); dest->tv_sec -= offset * 60; - dest->tv_nsec = 1000 * (src.centiseconds * 10000 + - src.hundredsOfMicroseconds * 100 + src.microseconds); + /* * Sanitize nanosecond field since reportedly some filesystems are * recorded with bogus sub-second values. */ - dest->tv_nsec %= NSEC_PER_SEC; + if (src.centiseconds < 100 && src.hundredsOfMicroseconds < 100 && + src.microseconds < 100) { + dest->tv_nsec = 1000 * (src.centiseconds * 10000 + + src.hundredsOfMicroseconds * 100 + src.microseconds); + } else { + dest->tv_nsec = 0; + } } void -- 2.43.0