From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5894817FAD4; Wed, 3 Jul 2024 11:05:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720004753; cv=none; b=jl39d5YXH3uXqJ7Bw7Zax7C48rhSlm6xb/46lFYH3bPWjfmEDlJ4aISV7dkuyRlHNCc4TtJfeJvS8MmemJh5qBQDQatFW17k6SaKzXbYZ2glrAQqAkhcqZpRMnGTfQQLzQPU2yAK0JAl5JeCS+Jfq6sjY/j1SRUYMIVmR2j+OuA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720004753; c=relaxed/simple; bh=ahJjbb6Ez6+f4Pm3f6IBb6nj/3hFG5IkeCm9ayGnQsQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GM7l/Py7YmT1qDUZjdn483fG2p3DNwoOKDgQdGj5M8Y7OBcgOAdLokx8WbfML52tpSTEjq4Tm2cXzxJx4ObT03GDBNhbzgtWcrdaYUMyphecJ5p6qMKxO3BTgcBEYRUTq+p/pS4ddyhz7N12xFhKPvIuwrGdW5GVfTtQHCXCEVI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=vKKhUHJM; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="vKKhUHJM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D352DC32781; Wed, 3 Jul 2024 11:05:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1720004753; bh=ahJjbb6Ez6+f4Pm3f6IBb6nj/3hFG5IkeCm9ayGnQsQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vKKhUHJMkCwjkOqoJdPN+0aMXXI7MDry54C+4Je1UkjlgkaPdLOoYKOWjo8xcZPxH zEu8660a+k8nWI+3Kjs5t/BBqBHdfdKgvvIyFBCFJN9OJXAjnKvW57wOSKbNcpr6jp eeGbAoKqmNbbdPLjoQRIXkAN4UdGwKAuvhFSOr+8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Shuang Li , Xin Long , Paolo Abeni , Sasha Levin Subject: [PATCH 5.10 147/290] tipc: force a dst refcount before doing decryption Date: Wed, 3 Jul 2024 12:38:48 +0200 Message-ID: <20240703102909.735967927@linuxfoundation.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240703102904.170852981@linuxfoundation.org> References: <20240703102904.170852981@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Xin Long [ Upstream commit 2ebe8f840c7450ecbfca9d18ac92e9ce9155e269 ] As it says in commit 3bc07321ccc2 ("xfrm: Force a dst refcount before entering the xfrm type handlers"): "Crypto requests might return asynchronous. In this case we leave the rcu protected region, so force a refcount on the skb's destination entry before we enter the xfrm type input/output handlers." On TIPC decryption path it has the same problem, and skb_dst_force() should be called before doing decryption to avoid a possible crash. Shuang reported this issue when this warning is triggered: [] WARNING: include/net/dst.h:337 tipc_sk_rcv+0x1055/0x1ea0 [tipc] [] Kdump: loaded Tainted: G W --------- - - 4.18.0-496.el8.x86_64+debug [] Workqueue: crypto cryptd_queue_worker [] RIP: 0010:tipc_sk_rcv+0x1055/0x1ea0 [tipc] [] Call Trace: [] tipc_sk_mcast_rcv+0x548/0xea0 [tipc] [] tipc_rcv+0xcf5/0x1060 [tipc] [] tipc_aead_decrypt_done+0x215/0x2e0 [tipc] [] cryptd_aead_crypt+0xdb/0x190 [] cryptd_queue_worker+0xed/0x190 [] process_one_work+0x93d/0x17e0 Fixes: fc1b6d6de220 ("tipc: introduce TIPC encryption & authentication") Reported-by: Shuang Li Signed-off-by: Xin Long Link: https://lore.kernel.org/r/fbe3195fad6997a4eec62d9bf076b2ad03ac336b.1718476040.git.lucien.xin@gmail.com Signed-off-by: Paolo Abeni Signed-off-by: Sasha Levin --- net/tipc/node.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/tipc/node.c b/net/tipc/node.c index 9e3cfeb82a23d..5f6866407be54 100644 --- a/net/tipc/node.c +++ b/net/tipc/node.c @@ -2076,6 +2076,7 @@ void tipc_rcv(struct net *net, struct sk_buff *skb, struct tipc_bearer *b) } else { n = tipc_node_find_by_id(net, ehdr->id); } + skb_dst_force(skb); tipc_crypto_rcv(net, (n) ? n->crypto_rx : NULL, &skb, b); if (!skb) return; -- 2.43.0