From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 956E1CA40; Tue, 16 Jul 2024 15:34:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721144044; cv=none; b=fVDxvp9bzl8+qtpuEyyBF8KIXfNf3qMo005ANjzdMJTCzo+9GAHDerKm1A1aOAw8c69rBjYs25DITK+RjiI5esJDnPlovY2gOQq+CISTq2zFbeDTZ6RgYpkcljrwwiAclF9u1pWZsgi69NZ4bfHNBVYegxbXovn0QFAEG8SRFu0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721144044; c=relaxed/simple; bh=9jEI5xG6HUcp3ygZVdbDhyQoJDDdFvK53ClBSlVyhms=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fU0pWu0gNhc/Vmx7gMsh/VBTnR1DSLbEZZGXMOM/cc3Mk5IsDcn4i7UwZc3FhFdwya+j3Zfj9yEV5vSNbilBHFf6z7TYcGpyrwIiJBxSZuZalSnwcBaIkAA1wupUDpPJTgwkRXg+v1uspJWUkccI27hqTZn/U9bnlPE7pw5IFyM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=rwZ4L31P; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="rwZ4L31P" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 985C1C116B1; Tue, 16 Jul 2024 15:34:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1721144044; bh=9jEI5xG6HUcp3ygZVdbDhyQoJDDdFvK53ClBSlVyhms=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rwZ4L31PYLHihV8+q5IH0gxBfru8iZdzBLvZIWizr6eZPy/Qg1H6vpR85UfrPsgEG gQro7qrOSDahtLjhr2vTUt22n0dQbKX2ZbpGvc6nxCOv8e5ijQCDyHcOfvbBPJkOS/ Dgodko0JNEuGonzC8UC9vpW7QyXRzgXFNcDRMLps= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Ricardo Ribalda , Hans Verkuil , Sasha Levin Subject: [PATCH 4.19 01/66] media: dvb: as102-fe: Fix as10x_register_addr packing Date: Tue, 16 Jul 2024 17:30:36 +0200 Message-ID: <20240716152738.221610486@linuxfoundation.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240716152738.161055634@linuxfoundation.org> References: <20240716152738.161055634@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ricardo Ribalda [ Upstream commit 309422d280748c74f57f471559980268ac27732a ] This structure is embedded in multiple other structures that are packed, which conflicts with it being aligned. drivers/media/usb/as102/as10x_cmd.h:379:30: warning: field reg_addr within 'struct as10x_dump_memory::(unnamed at drivers/media/usb/as102/as10x_cmd.h:373:2)' is less aligned than 'struct as10x_register_addr' and is usually due to 'struct as10x_dump_memory::(unnamed at drivers/media/usb/as102/as10x_cmd.h:373:2)' being packed, which can lead to unaligned accesses [-Wunaligned-access] Mark it as being packed. Marking the inner struct as 'packed' does not change the layout, since the whole struct is already packed, it just silences the clang warning. See also this llvm discussion: https://github.com/llvm/llvm-project/issues/55520 Signed-off-by: Ricardo Ribalda Signed-off-by: Hans Verkuil Signed-off-by: Sasha Levin --- drivers/media/dvb-frontends/as102_fe_types.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/dvb-frontends/as102_fe_types.h b/drivers/media/dvb-frontends/as102_fe_types.h index 80a5398b580fe..661d7574a6c73 100644 --- a/drivers/media/dvb-frontends/as102_fe_types.h +++ b/drivers/media/dvb-frontends/as102_fe_types.h @@ -183,6 +183,6 @@ struct as10x_register_addr { uint32_t addr; /* register mode access */ uint8_t mode; -}; +} __packed; #endif -- 2.43.0