From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 462ACE541; Tue, 16 Jul 2024 15:38:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721144310; cv=none; b=ABgpe9Joqr45UHpLS3JDg3ueooDV+pFcMaDqlyO0NUnEWy0wAQEWwP6B6vZlwmsTW1zgVMgT4T9c1lBpD3FpD5glFKC+RnB8+YRiK5uV3MAmfUkP2qngOxM1WlSnNtlVqbGTKsYioZqFuFVQhkwbwYJcBsrwXfoI86lExCBLhTg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721144310; c=relaxed/simple; bh=IfYtF3jndenVUOzjCXh1+pw5puSTrABOOCrEhW2apFU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UoCPpUvrUmheimRbNlDTL8Su2pYQ5KJ8vGNxON5nw0sbYTI4Yz18nF2hWytWZzDhoviGBQoLQ+yqaROmNe9sPfoSSareywdqmwyZvmz8jBO7HHBtIiio5h75Nf66dqDairdEH8on3YpNn5eWpsANUtiVnAmkzfX5Fdsl18vhSLo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=UY76xxe1; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="UY76xxe1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8DF67C116B1; Tue, 16 Jul 2024 15:38:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1721144310; bh=IfYtF3jndenVUOzjCXh1+pw5puSTrABOOCrEhW2apFU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UY76xxe1feZTyJW1bTomEOGqkEG9lZLbHI8SnHYR5R6Ej4O6EHIB8EEbtaiUd7hrD iaEhf8/G8CTlkTUycnE+lLpYJ0FGDuu2vB5hX9NKOskhInstlYHHtFv0sYeqCFSsWl H16PixKsWwEZvVezsQXrP313o1rQWOriJV45O+kw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Zijian Zhang , Xiaochun Lu , Willem de Bruijn , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.4 30/78] selftests: make order checking verbose in msg_zerocopy selftest Date: Tue, 16 Jul 2024 17:31:02 +0200 Message-ID: <20240716152741.803529010@linuxfoundation.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240716152740.626160410@linuxfoundation.org> References: <20240716152740.626160410@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Zijian Zhang [ Upstream commit 7d6d8f0c8b700c9493f2839abccb6d29028b4219 ] We find that when lock debugging is on, notifications may not come in order. Thus, we have order checking outputs managed by cfg_verbose, to avoid too many outputs in this case. Fixes: 07b65c5b31ce ("test: add msg_zerocopy test") Signed-off-by: Zijian Zhang Signed-off-by: Xiaochun Lu Reviewed-by: Willem de Bruijn Link: https://patch.msgid.link/20240701225349.3395580-3-zijianzhang@bytedance.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- tools/testing/selftests/net/msg_zerocopy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/net/msg_zerocopy.c b/tools/testing/selftests/net/msg_zerocopy.c index 926556febc83c..7ea5fb28c93db 100644 --- a/tools/testing/selftests/net/msg_zerocopy.c +++ b/tools/testing/selftests/net/msg_zerocopy.c @@ -438,7 +438,7 @@ static bool do_recv_completion(int fd, int domain) /* Detect notification gaps. These should not happen often, if at all. * Gaps can occur due to drops, reordering and retransmissions. */ - if (lo != next_completion) + if (cfg_verbose && lo != next_completion) fprintf(stderr, "gap: %u..%u does not append to %u\n", lo, hi, next_completion); next_completion = hi + 1; -- 2.43.0