From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: stable@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
patches@lists.linux.dev,
Richard Fitzgerald <rf@opensource.cirrus.com>,
Mark Brown <broonie@kernel.org>
Subject: [PATCH 6.10 8/9] ASoC: cs35l56: Use header defines for Speaker Volume control definition
Date: Tue, 23 Jul 2024 13:52:02 +0200 [thread overview]
Message-ID: <20240723114047.577982361@linuxfoundation.org> (raw)
In-Reply-To: <20240723114047.281580960@linuxfoundation.org>
6.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: Richard Fitzgerald <rf@opensource.cirrus.com>
commit c66995ae403073212f5ba60d2079003866c6e130 upstream.
The "Speaker Volume" control was being defined using four hardcoded magic
numbers. There are #defines in the cs35l56.h header for these numbers, so
change the code to use the defined constants.
Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Link: https://patch.msgid.link/20240703095517.208077-2-rf@opensource.cirrus.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
sound/soc/codecs/cs35l56.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
--- a/sound/soc/codecs/cs35l56.c
+++ b/sound/soc/codecs/cs35l56.c
@@ -196,7 +196,11 @@ static const struct snd_kcontrol_new cs3
cs35l56_dspwait_get_volsw, cs35l56_dspwait_put_volsw),
SOC_SINGLE_S_EXT_TLV("Speaker Volume",
CS35L56_MAIN_RENDER_USER_VOLUME,
- 6, -400, 400, 9, 0,
+ CS35L56_MAIN_RENDER_USER_VOLUME_SHIFT,
+ CS35L56_MAIN_RENDER_USER_VOLUME_MIN,
+ CS35L56_MAIN_RENDER_USER_VOLUME_MAX,
+ CS35L56_MAIN_RENDER_USER_VOLUME_SIGNBIT,
+ 0,
cs35l56_dspwait_get_volsw,
cs35l56_dspwait_put_volsw,
vol_tlv),
next prev parent reply other threads:[~2024-07-23 11:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-23 11:51 [PATCH 6.10 0/9] 6.10.1-rc1 review Greg Kroah-Hartman
2024-07-23 11:51 ` [PATCH 6.10 1/9] ext4: use memtostr_pad() for s_volume_name Greg Kroah-Hartman
2024-07-23 11:51 ` [PATCH 6.10 2/9] cifs: Fix missing error code set Greg Kroah-Hartman
2024-07-23 11:51 ` [PATCH 6.10 3/9] cifs: Fix missing fscache invalidation Greg Kroah-Hartman
2024-07-23 11:51 ` [PATCH 6.10 4/9] cifs: fix noisy message on copy_file_range Greg Kroah-Hartman
2024-07-23 11:51 ` [PATCH 6.10 5/9] cifs: Fix server re-repick on subrequest retry Greg Kroah-Hartman
2024-07-23 11:52 ` [PATCH 6.10 6/9] cifs: Fix setting of zero_point after DIO write Greg Kroah-Hartman
2024-07-23 11:52 ` [PATCH 6.10 7/9] tpm: Use auth only after NULL check in tpm_buf_check_hmac_response() Greg Kroah-Hartman
2024-07-23 11:52 ` Greg Kroah-Hartman [this message]
2024-07-23 11:52 ` [PATCH 6.10 9/9] ASoC: cs35l56: Limit Speaker Volume to +12dB maximum Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240723114047.577982361@linuxfoundation.org \
--to=gregkh@linuxfoundation.org \
--cc=broonie@kernel.org \
--cc=patches@lists.linux.dev \
--cc=rf@opensource.cirrus.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox