Archive-only list for patches
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: stable@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	patches@lists.linux.dev, Yunseong Kim <yskelg@gmail.com>,
	Alexander Gordeev <agordeev@linux.ibm.com>,
	Gerald Schaefer <gerald.schaefer@linux.ibm.com>,
	Vasily Gorbik <gor@linux.ibm.com>
Subject: [PATCH 6.10 02/29] s390/mm: Fix VM_FAULT_HWPOISON handling in do_exception()
Date: Thu, 25 Jul 2024 16:36:18 +0200	[thread overview]
Message-ID: <20240725142731.910029742@linuxfoundation.org> (raw)
In-Reply-To: <20240725142731.814288796@linuxfoundation.org>

6.10-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Gerald Schaefer <gerald.schaefer@linux.ibm.com>

commit df39038cd89525d465c2c8827eb64116873f141a upstream.

There is no support for HWPOISON, MEMORY_FAILURE, or ARCH_HAS_COPY_MC on
s390. Therefore we do not expect to see VM_FAULT_HWPOISON in
do_exception().

However, since commit af19487f00f3 ("mm: make PTE_MARKER_SWAPIN_ERROR more
general"), it is possible to see VM_FAULT_HWPOISON in combination with
PTE_MARKER_POISONED, even on architectures that do not support HWPOISON
otherwise. In this case, we will end up on the BUG() in do_exception().

Fix this by treating VM_FAULT_HWPOISON the same as VM_FAULT_SIGBUS, similar
to x86 when MEMORY_FAILURE is not configured. Also print unexpected fault
flags, for easier debugging.

Note that VM_FAULT_HWPOISON_LARGE is not expected, because s390 cannot
support swap entries on other levels than PTE level.

Cc: stable@vger.kernel.org # 6.6+
Fixes: af19487f00f3 ("mm: make PTE_MARKER_SWAPIN_ERROR more general")
Reported-by: Yunseong Kim <yskelg@gmail.com>
Tested-by: Yunseong Kim <yskelg@gmail.com>
Acked-by: Alexander Gordeev <agordeev@linux.ibm.com>
Signed-off-by: Gerald Schaefer <gerald.schaefer@linux.ibm.com>
Message-ID: <20240715180416.3632453-1-gerald.schaefer@linux.ibm.com>
Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 arch/s390/mm/fault.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--- a/arch/s390/mm/fault.c
+++ b/arch/s390/mm/fault.c
@@ -433,12 +433,13 @@ error:
 			handle_fault_error_nolock(regs, 0);
 		else
 			do_sigsegv(regs, SEGV_MAPERR);
-	} else if (fault & VM_FAULT_SIGBUS) {
+	} else if (fault & (VM_FAULT_SIGBUS | VM_FAULT_HWPOISON)) {
 		if (!user_mode(regs))
 			handle_fault_error_nolock(regs, 0);
 		else
 			do_sigbus(regs);
 	} else {
+		pr_emerg("Unexpected fault flags: %08x\n", fault);
 		BUG();
 	}
 }



  parent reply	other threads:[~2024-07-25 14:38 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-25 14:36 [PATCH 6.10 00/29] 6.10.2-rc1 review Greg Kroah-Hartman
2024-07-25 14:36 ` [PATCH 6.10 01/29] drm/amdgpu: Fix signedness bug in sdma_v4_0_process_trap_irq() Greg Kroah-Hartman
2024-07-25 14:36 ` Greg Kroah-Hartman [this message]
2024-07-25 14:36 ` [PATCH 6.10 03/29] ocfs2: add bounds checking to ocfs2_check_dir_entry() Greg Kroah-Hartman
2024-07-25 14:36 ` [PATCH 6.10 04/29] jfs: dont walk off the end of ealist Greg Kroah-Hartman
2024-07-25 14:36 ` [PATCH 6.10 05/29] fs/ntfs3: Add a check for attr_names and oatbl Greg Kroah-Hartman
2024-07-25 14:36 ` [PATCH 6.10 06/29] fs/ntfs3: Validate ff offset Greg Kroah-Hartman
2024-07-25 14:36 ` [PATCH 6.10 07/29] usb: gadget: midi2: Fix incorrect default MIDI2 protocol setup Greg Kroah-Hartman
2024-07-25 14:36 ` [PATCH 6.10 08/29] ALSA: hda/tas2781: Add new quirk for Lenovo Hera2 Laptop Greg Kroah-Hartman
2024-07-25 14:36 ` [PATCH 6.10 09/29] ALSA: hda/realtek: Enable headset mic on Positivo SU C1400 Greg Kroah-Hartman
2024-07-25 14:36 ` [PATCH 6.10 10/29] ALSA: hda/realtek: Fix the speaker output on Samsung Galaxy Book Pro 360 Greg Kroah-Hartman
2024-07-25 14:36 ` [PATCH 6.10 11/29] arm64: dts: qcom: sc7180: Disable SuperSpeed instances in park mode Greg Kroah-Hartman
2024-07-25 14:36 ` [PATCH 6.10 12/29] arm64: dts: qcom: sc7280: " Greg Kroah-Hartman
2024-07-25 14:36 ` [PATCH 6.10 13/29] arm64: dts: qcom: x1e80100-qcp: Fix USB PHYs regulators Greg Kroah-Hartman
2024-07-25 14:36 ` [PATCH 6.10 14/29] arm64: dts: qcom: qrb2210-rb1: switch I2C2 to i2c-gpio Greg Kroah-Hartman
2024-07-25 14:36 ` [PATCH 6.10 15/29] arm64: dts: qcom: qrb4210-rb2: " Greg Kroah-Hartman
2024-07-25 14:36 ` [PATCH 6.10 16/29] arm64: dts: qcom: x1e80100-crd: Fix the PHY regulator for PCIe 6a Greg Kroah-Hartman
2024-07-25 14:36 ` [PATCH 6.10 17/29] arm64: dts: qcom: x1e80100-qcp: " Greg Kroah-Hartman
2024-07-25 14:36 ` [PATCH 6.10 18/29] arm64: dts: qcom: x1e80100-crd: Fix USB PHYs regulators Greg Kroah-Hartman
2024-07-25 14:36 ` [PATCH 6.10 19/29] arm64: dts: qcom: msm8996: Disable SS instance in Parkmode for USB Greg Kroah-Hartman
2024-07-25 14:36 ` [PATCH 6.10 20/29] arm64: dts: qcom: sm6350: " Greg Kroah-Hartman
2024-07-25 14:36 ` [PATCH 6.10 21/29] arm64: dts: qcom: msm8998: " Greg Kroah-Hartman
2024-07-25 14:36 ` [PATCH 6.10 22/29] arm64: dts: qcom: ipq6018: " Greg Kroah-Hartman
2024-07-25 14:36 ` [PATCH 6.10 23/29] arm64: dts: qcom: sdm630: " Greg Kroah-Hartman
2024-07-25 14:36 ` [PATCH 6.10 24/29] arm64: dts: qcom: ipq8074: " Greg Kroah-Hartman
2024-07-25 14:36 ` [PATCH 6.10 25/29] arm64: dts: qcom: sdm845: " Greg Kroah-Hartman
2024-07-25 14:36 ` [PATCH 6.10 26/29] arm64: dts: qcom: sm6115: " Greg Kroah-Hartman
2024-07-25 14:36 ` [PATCH 6.10 27/29] ALSA: pcm_dmaengine: Dont synchronize DMA channel when DMA is paused Greg Kroah-Hartman
2024-07-25 14:36 ` [PATCH 6.10 28/29] ALSA: seq: ump: Skip useless ports for static blocks Greg Kroah-Hartman
2024-07-25 14:36 ` [PATCH 6.10 29/29] filelock: Fix fcntl/close race recovery compat path Greg Kroah-Hartman
2024-07-25 23:23 ` [PATCH 6.10 00/29] 6.10.2-rc1 review SeongJae Park
2024-07-26  0:35 ` Justin Forbes
2024-07-26  8:46 ` Ron Economos
2024-07-26 11:27 ` Mark Brown
2024-07-26 12:47 ` Rudi Heitbaum
2024-07-26 16:28 ` Shuah Khan
2024-07-26 17:18 ` Jon Hunter
2024-07-26 17:48 ` Naresh Kamboju
2024-07-26 20:37 ` Florian Fainelli
2024-07-26 21:27 ` Christian Heusel
2024-07-27  1:05 ` Peter Schneider

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240725142731.910029742@linuxfoundation.org \
    --to=gregkh@linuxfoundation.org \
    --cc=agordeev@linux.ibm.com \
    --cc=gerald.schaefer@linux.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=patches@lists.linux.dev \
    --cc=stable@vger.kernel.org \
    --cc=yskelg@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox