From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9ED218468; Thu, 25 Jul 2024 14:48:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721918889; cv=none; b=QVKKoDNemhPHMI40o7eDGJQQCm0xI+p/pGzip8trFmUip6KkLhZTBal85Ld+VHGoLD9IsoS+V/TvLhnyRtXN80c7TqMCV0g4hle9ofaor5P92Kkgs8XrkwLGf8YlZQirFrLn+p/7rJkDR1OE5AU1NHlYWHgoReFMDv1Cmwy6bms= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721918889; c=relaxed/simple; bh=w+zJjzM8kSxU2v8WuYuGJF+u3OPt/g3DQJyYaFkp5vY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Nr/xcLM8WAcqNPLc2uh/NOyLa/rtXHoF3RG7tlRysldVX9SUoccmGzjcSQeiNwmnyr3rJkcrE6RAgS0lbXjSY/ZVQP+aJWg/GSIYpiqgJGWG5NsSV0nbR/z+7AY1cfYEhVbk3bd9KsbkhZMoCcbNuoVYeEx+uJhTuzXXiG4xSPg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=UUF3slGG; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="UUF3slGG" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 23F43C116B1; Thu, 25 Jul 2024 14:48:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1721918889; bh=w+zJjzM8kSxU2v8WuYuGJF+u3OPt/g3DQJyYaFkp5vY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UUF3slGG93tlUA/i8szQtQzeiGvENMB7Nu1nLvg2BAM6qgVQhyhbBmVqJEavZWS75 iJjnwsHI0AID6ZStNi5QC1AWc48MpEllkS/yC7woymX9GzcRvaktB0XFYDy9L0Ln0T Q1bne3zD20ZLcKW5ytCpZKe0EEAhPTtcDLhlmhFM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, stable@kernel.org, Jann Horn , Jeff Layton , Christian Brauner Subject: [PATCH 5.10 02/59] filelock: Remove locks reliably when fcntl/close race is detected Date: Thu, 25 Jul 2024 16:36:52 +0200 Message-ID: <20240725142733.356390890@linuxfoundation.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240725142733.262322603@linuxfoundation.org> References: <20240725142733.262322603@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jann Horn commit 3cad1bc010416c6dd780643476bc59ed742436b9 upstream. When fcntl_setlk() races with close(), it removes the created lock with do_lock_file_wait(). However, LSMs can allow the first do_lock_file_wait() that created the lock while denying the second do_lock_file_wait() that tries to remove the lock. In theory (but AFAIK not in practice), posix_lock_file() could also fail to remove a lock due to GFP_KERNEL allocation failure (when splitting a range in the middle). After the bug has been triggered, use-after-free reads will occur in lock_get_status() when userspace reads /proc/locks. This can likely be used to read arbitrary kernel memory, but can't corrupt kernel memory. This only affects systems with SELinux / Smack / AppArmor / BPF-LSM in enforcing mode and only works from some security contexts. Fix it by calling locks_remove_posix() instead, which is designed to reliably get rid of POSIX locks associated with the given file and files_struct and is also used by filp_flush(). Fixes: c293621bbf67 ("[PATCH] stale POSIX lock handling") Cc: stable@kernel.org Link: https://bugs.chromium.org/p/project-zero/issues/detail?id=2563 Signed-off-by: Jann Horn Link: https://lore.kernel.org/r/20240702-fs-lock-recover-2-v1-1-edd456f63789@google.com Reviewed-by: Jeff Layton Signed-off-by: Christian Brauner [stable fixup: ->c.flc_type was ->fl_type in older kernels] Signed-off-by: Jann Horn Signed-off-by: Greg Kroah-Hartman --- fs/locks.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) --- a/fs/locks.c +++ b/fs/locks.c @@ -2588,8 +2588,9 @@ int fcntl_setlk(unsigned int fd, struct error = do_lock_file_wait(filp, cmd, file_lock); /* - * Attempt to detect a close/fcntl race and recover by releasing the - * lock that was just acquired. There is no need to do that when we're + * Detect close/fcntl races and recover by zapping all POSIX locks + * associated with this file and our files_struct, just like on + * filp_flush(). There is no need to do that when we're * unlocking though, or for OFD locks. */ if (!error && file_lock->fl_type != F_UNLCK && @@ -2604,9 +2605,7 @@ int fcntl_setlk(unsigned int fd, struct f = files_lookup_fd_locked(files, fd); spin_unlock(&files->file_lock); if (f != filp) { - file_lock->fl_type = F_UNLCK; - error = do_lock_file_wait(filp, cmd, file_lock); - WARN_ON_ONCE(error); + locks_remove_posix(filp, files); error = -EBADF; } }