From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A330F19A29C; Thu, 25 Jul 2024 14:47:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721918863; cv=none; b=m/C4TOgMDrMSQQUtsQodlkke/q4U3ENNypgYb1g1KW8AbS9EZBalZ2SKcyaV0hF2gjWJwC1WcbVtlABf7FeMc574C9LhPNmcNA302izKVwImfXWf5q91A7JfzR7XgWU7nB/mHR5jE0z+qZDN7SLlTTkVz2sYVb8LfZ1tWpKHxHo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721918863; c=relaxed/simple; bh=bwxqBYfPAfL1ST7N59QgIRByCvn8h+RStkc+FtxCxpc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iHKAXOMK3lJaVlDznR6YrbBpY/cdBTIwtmEyl4gIEsGltT4x9eJDXMZ7xNx13aymg86ZyQp8wbfmWCJa9DImxHwaSPvb9NeoKpMENxpiS8hG+N4FN4RpyWMvM5g82u3RjvgjDy42DebMJTjmnk28bW7J+kosyaC1+pnu+OMEI0s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=SUINW9VP; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="SUINW9VP" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B1EF5C116B1; Thu, 25 Jul 2024 14:47:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1721918863; bh=bwxqBYfPAfL1ST7N59QgIRByCvn8h+RStkc+FtxCxpc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SUINW9VPo0pY8kwuJ3Wo1vRW2q9Jj1aQu7ymwp4Zu9GNSYl4J3Ilwg9h9NY+KnLaa cQGuy46i4XkrI692EJdi/a9TDu8eTtrRUlrGTekteMkAEznPwDLimvAF/mcpRM4XEc 75jYEM5c1tG5naVmdFzwkGrVJL3Q6RDsme9PoUXw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Wei Li , Huisong Li , Will Deacon , Sasha Levin Subject: [PATCH 5.10 12/59] arm64: armv8_deprecated: Fix warning in isndep cpuhp starting process Date: Thu, 25 Jul 2024 16:37:02 +0200 Message-ID: <20240725142733.731217445@linuxfoundation.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240725142733.262322603@linuxfoundation.org> References: <20240725142733.262322603@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Wei Li [ Upstream commit 14951beaec93696b092a906baa0f29322cf34004 ] The function run_all_insn_set_hw_mode() is registered as startup callback of 'CPUHP_AP_ARM64_ISNDEP_STARTING', it invokes set_hw_mode() methods of all emulated instructions. As the STARTING callbacks are not expected to fail, if one of the set_hw_mode() fails, e.g. due to el0 mixed-endian is not supported for 'setend', it will report a warning: ``` CPU[2] cannot support the emulation of setend CPU 2 UP state arm64/isndep:starting (136) failed (-22) CPU2: Booted secondary processor 0x0000000002 [0x414fd0c1] ``` To fix it, add a check for INSN_UNAVAILABLE status and skip the process. Signed-off-by: Wei Li Tested-by: Huisong Li Link: https://lore.kernel.org/r/20240423093501.3460764-1-liwei391@huawei.com Signed-off-by: Will Deacon Signed-off-by: Sasha Levin --- arch/arm64/kernel/armv8_deprecated.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm64/kernel/armv8_deprecated.c b/arch/arm64/kernel/armv8_deprecated.c index f0ba854f0045e..34370be75acd5 100644 --- a/arch/arm64/kernel/armv8_deprecated.c +++ b/arch/arm64/kernel/armv8_deprecated.c @@ -471,6 +471,9 @@ static int run_all_insn_set_hw_mode(unsigned int cpu) for (i = 0; i < ARRAY_SIZE(insn_emulations); i++) { struct insn_emulation *insn = insn_emulations[i]; bool enable = READ_ONCE(insn->current_mode) == INSN_HW; + if (insn->status == INSN_UNAVAILABLE) + continue; + if (insn->set_hw_mode && insn->set_hw_mode(enable)) { pr_warn("CPU[%u] cannot support the emulation of %s", cpu, insn->name); -- 2.43.0